chore: address comment + run in ci

AztecProtocol · Aug 30, 2024 · 45e21fa · 45e21fa
1 parent 434aada
commit 45e21fa
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/yarn-project/end-to-end/Earthfile b/yarn-project/end-to-end/Earthfile
@@ -110,6 +110,9 @@ NETWORK_TEST:
 e2e-p2p:
   DO +E2E_TEST --test=./src/e2e_p2p_network.test.ts
 
+e2e-devnet:
+  DO +E2E_TEST --test=./src/e2e_devnet.test.ts
+
 e2e-2-pxes:
   DO +E2E_TEST --test=./src/e2e_2_pxes.test.ts
 

diff --git a/yarn-project/end-to-end/src/e2e_devnet.test.ts b/yarn-project/end-to-end/src/e2e_devnet.test.ts
@@ -37,7 +37,6 @@ describe('e2e_devnet', () => {
   const submitTxsTo = async (pxe: PXEService, numTxs: number) => {
     const txs: SentTx[] = [];
     for (let i = 0; i < numTxs; i++) {
-      // const tx = getSchnorrAccount(pxe, Fr.random(), GrumpkinScalar.random(), Fr.random()).deploy();
       const accountManager = getSchnorrAccount(pxe, Fr.random(), GrumpkinScalar.random(), Fr.random());
       const deployMethod = await accountManager.getDeployMethod();
       await deployMethod.create({

diff --git a/yarn-project/sequencer-client/src/sequencer/sequencer.ts b/yarn-project/sequencer-client/src/sequencer/sequencer.ts
@@ -513,12 +513,12 @@ export class Sequencer {
 
     if (committee.length === 0) {
       return undefined;
-    } else {
-      if (!this.validatorClient) {
-        const msg = 'Missing validator client: Cannot collect attestations';
-        this.log.error(msg);
-        throw new Error(msg);
-      }
+    }
+
+    if (!this.validatorClient) {
+      const msg = 'Missing validator client: Cannot collect attestations';
+      this.log.error(msg);
+      throw new Error(msg);
     }
 
     const numberOfRequiredAttestations = Math.floor((committee.length * 2) / 3) + 1;