Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs in private kernel #636

Merged
merged 49 commits into from
Jun 7, 2023
Merged

Logs in private kernel #636

merged 49 commits into from
Jun 7, 2023

Conversation

benesjan
Copy link
Contributor

Description

Fixes #589

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@benesjan benesjan marked this pull request as draft May 22, 2023 11:22
@benesjan benesjan force-pushed the janb/logs-in-kernel branch 6 times, most recently from da58fe6 to 557c6b0 Compare May 23, 2023 13:49
This was referenced May 30, 2023
Closed
Closed
@benesjan benesjan force-pushed the janb/logs-in-kernel branch 4 times, most recently from 736256e to f95ec0e Compare June 5, 2023 11:21
@benesjan benesjan mentioned this pull request Jun 5, 2023
Merged
6 tasks
@benesjan benesjan changed the title Logs in kernel Logs in private kernel Jun 6, 2023
@benesjan benesjan force-pushed the janb/logs-in-kernel branch from 870ebe7 to 230c1ce Compare June 6, 2023 09:24
@benesjan benesjan marked this pull request as ready for review June 6, 2023 12:49
spypsy
spypsy reviewed Jun 6, 2023
View reviewed changes
Copy link
Member

@spypsy spypsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me to the extend I can understand

spalladino
spalladino approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

circuits/cpp/src/aztec3/circuits/abis/combined_accumulated_data.hpp Show resolved Hide resolved
yarn-project/circuits.js/src/structs/private_circuit_public_inputs.ts Outdated Show resolved Hide resolved
yarn-project/circuits.js/src/tests/factories.ts Outdated Show resolved Hide resolved
yarn-project/noir-contracts/src/contracts/noir-aztec3/src/abi.nr Outdated Show resolved Hide resolved
benesjan and others added 27 commits June 7, 2023 07:37
@benesjan
fix: serialization
49473f2
@benesjan
test: updated snapshots 2
e2d5a4e
@benesjan
too many unknowns fix attemp
2ec9a70
@spalladino @benesjan
Hack around "too many unknowns"
b0fbc7f
@benesjan
style: formatting fix
9d47d7c
@benesjan
docs: added few TODOs
449213f
@benesjan
chore: updated snapshots
4dfac9b
@benesjan
Revert "too many unknowns fix attemp"
8f74950 
This reverts commit c29f9e7.
@benesjan
test: updated snapshots
7ce2cf2
@benesjan
refactor: commented out all logs changes in Noir contracts
25cc0eb
@benesjan
chore: Noir workaround in deserialize.ts
38eede5
@benesjan
chore: updates after rebase
2a71869
@benesjan
fix: printout
5754384
@benesjan
fix: correct PUBLIC_INPUTS_LENGTH + recompiled contracts
c1abffb
@benesjan
test: checking if full CI passes if I disable problematic test
aac11f1
@benesjan
test: updated snapshots
6bd8a1f
@benesjan
Revert "test: checking if full CI passes if I disable problematic test"
6a5bf99 
This reverts commit 7adb2d9.
@benesjan
fix: updated PUBLIC_CIRCUIT_PUBLIC_INPUTS_SIZE
2159fb9
@benesjan
fix
cfebdb1
@benesjan
chore: refreshed circuits.gen.ts
3c86bb7
@benesjan
docs: linking relevant issue
6b274ec
@benesjan
fix: reverted incorrectly introduced change
f953020
@benesjan
docs: comment
481c07b
@benesjan
test: updated snapshots
372c1cd
@benesjan
refactor: better logs hash type
a85bf5e
@benesjan
test: better initialization of log vars
6d33f41
@benesjan
chore: recompiled noir contracts
a0024b1
@benesjan benesjan force-pushed the janb/logs-in-kernel branch from 978ab0a to a0024b1 Compare June 7, 2023 08:14
@benesjan benesjan merged commit cc923b9 into master Jun 7, 2023
@benesjan benesjan deleted the janb/logs-in-kernel branch June 7, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul-kothari rahul-kothari rahul-kothari approved these changes

@spypsy spypsy spypsy left review comments

@spalladino spalladino spalladino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update private kernel circuit to propagate hashes and pre-image lengths
4 participants
@benesjan @spalladino @spypsy @rahul-kothari