Logs in base rollup circuit #746

benesjan · 2023-06-05T13:14:16Z

Description

Fixes #606

I have reviewed my diff in github, line by line.
Every change is related to the PR description.
I have linked this pull request to the issue(s) that it resolves.
There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
The branch has been merged or rebased against the head of its merge target.
I'm happy for the PR to be merged at the reviewer's next convenience.

benesjan changed the base branch from master to janb/logs-in-kernel June 5, 2023 13:14

benesjan marked this pull request as draft June 5, 2023 13:15

benesjan force-pushed the janb/logs-in-kernel branch 2 times, most recently from 978ab0a to a0024b1 Compare June 7, 2023 08:14

Base automatically changed from janb/logs-in-kernel to master June 7, 2023 08:45

benesjan force-pushed the janb/logs-in-base-rollup-circuit branch 2 times, most recently from a2e5b9e to 4297804 Compare June 7, 2023 15:04

benesjan marked this pull request as ready for review June 7, 2023 15:29

benesjan requested review from rahul-kothari, spypsy and spalladino June 7, 2023 15:31

feat: including encrypted logs hash in calldata hash preimage

85e1fb9

benesjan force-pushed the janb/logs-in-base-rollup-circuit branch from cabaf58 to 9354384 Compare June 7, 2023 18:41

chore: commenting out logs code to make CI pass

c9c5f1e

benesjan force-pushed the janb/logs-in-base-rollup-circuit branch from 9354384 to c9c5f1e Compare June 7, 2023 19:34

spypsy approved these changes Jun 8, 2023

View reviewed changes

spalladino approved these changes Jun 8, 2023

View reviewed changes

rahul-kothari approved these changes Jun 8, 2023

View reviewed changes

Merge branch 'master' into janb/logs-in-base-rollup-circuit

37abdfa

benesjan merged commit 78fe0b7 into master Jun 8, 2023

benesjan deleted the janb/logs-in-base-rollup-circuit branch June 8, 2023 13:42