Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1242 - e2e test related to the filtering of get_notes #1570

Merged
merged 1 commit into from
Aug 15, 2023
Merged

1242 - e2e test related to the filtering of get_notes #1570

merged 1 commit into from
Aug 15, 2023

Conversation

jeanmon
Copy link
Contributor

@jeanmon jeanmon commented Aug 15, 2023 •
edited
Loading

Solves #1242

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@jeanmon jeanmon marked this pull request as ready for review August 15, 2023 14:09
@jeanmon jeanmon requested a review from dbanks12 August 15, 2023 14:10
@jeanmon jeanmon force-pushed the jm/1242-e2e-getnotes-pend-null branch from b714e84 to 1d2c43c Compare August 15, 2023 14:45
dbanks12
dbanks12 approved these changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, LGTM. No feedback on my end.

@dbanks12 dbanks12 merged commit 440a9b4 into master Aug 15, 2023
@dbanks12 dbanks12 deleted the jm/1242-e2e-getnotes-pend-null branch August 15, 2023 15:21
@Maddiaa0 Maddiaa0 mentioned this pull request Aug 15, 2023
Merged
Maddiaa0 added a commit that referenced this pull request Aug 15, 2023
@Maddiaa0
chore: fix dirty merge (#1574)
58dc9bf 
fixes dirty merge between #1570 and #1515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanks12 dbanks12 dbanks12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanmon @dbanks12