Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the toFields serialization to the classes themselves #4332

Closed
Tracked by #4231
benesjan opened this issue Jan 31, 2024 · 0 comments · Fixed by #4335
Closed
Tracked by #4231

Move the toFields serialization to the classes themselves #4332

benesjan opened this issue Jan 31, 2024 · 0 comments · Fixed by #4335
Assignees
@benesjan

Comments

@benesjan
Copy link
Contributor

benesjan commented Jan 31, 2024 •
edited
Loading

Move the serialization functionality which is used when creating the witness to the classes to minimize probability of forgetting to do a change when changing something (e.g. functions like toACVMFunctionData or toACVMCallContext should be in the classes).
@benesjan benesjan mentioned this issue Jan 31, 2024
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Jan 31, 2024
@benesjan benesjan changed the title Move the serialization functionality which is used when creating the witness to the classes to minimize probability of forgetting to do a change when changing something (e.g. functions like toACVMFunctionData or toACVMCallContext should be in the classes). Move the toFields serialization to the classes themselves Jan 31, 2024
@benesjan benesjan self-assigned this Jan 31, 2024
@benesjan benesjan mentioned this issue Jan 31, 2024
Merged
benesjan added a commit that referenced this issue Feb 1, 2024
@benesjan
refactor: toFields()/fromFields(...) methods in more classes (#4335)
433b9eb 
Partially fixes #4332

The goal of this PR was to progress on nuking
yarn-project/acir-simulator/src/acvm/serialize.ts and move it to the
individual classes to then be able to easily test it in the classes
tests and improve readability.

I didn't fully tackle the issue in this one because it was all getting
too big.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Feb 1, 2024
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@benesjan
refactor: toFields()/fromFields(...) methods in more classes (Azt…
7447584 
…ecProtocol#4335)

Partially fixes AztecProtocol#4332

The goal of this PR was to progress on nuking
yarn-project/acir-simulator/src/acvm/serialize.ts and move it to the
individual classes to then be able to easily test it in the classes
tests and improve readability.

I didn't fully tackle the issue in this one because it was all getting
too big.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: toFields()/fromFields(...) methods in more classes AztecProtocol/aztec-packages
1 participant
@benesjan