Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better testing of serialization between Noir and TS #4231

Closed
1 of 2 tasks
benesjan opened this issue Jan 26, 2024 · 1 comment
Closed
1 of 2 tasks

Better testing of serialization between Noir and TS #4231

benesjan opened this issue Jan 26, 2024 · 1 comment
Assignees

Comments

@benesjan
Copy link
Contributor

benesjan commented Jan 26, 2024

We don't sufficiently test that the serialization in Noir matches that of TS.

I propose the following to address this:

  1. For each struct which has both Noir and TS representation check that serialization of non-empty instance results in the same value.
  2. Move the serialization functionality which is used when creating the witness to the classes to minimize probability of forgetting to do a change when changing something (e.g. functions like toACVMFunctionData or toACVMCallContext should be in the classes).

Tasks

Preview Give feedback
  1. benesjan
@benesjan
Copy link
Contributor Author

benesjan commented Feb 5, 2024

Partially tackled and the rest replaced with #4412

@benesjan benesjan closed this as completed Feb 5, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant