Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bb.js-dev script was not working #1666

Closed
kevaundray opened this issue Aug 18, 2023 · 2 comments
Closed

bb.js-dev script was not working #1666

kevaundray opened this issue Aug 18, 2023 · 2 comments
Assignees
Labels
C-bb.js Component: bb.js - wrapping bberg in js

Comments

@kevaundray
Copy link
Contributor

This is a retroactive issue. The PR has been made here

Problem

As a part of #1640 , the bb.js-dev script was removed because it was not running tests, instead it was printing out the nodemon version.

To reproduce, one can build the repository before that PR.

Solution

The solution was to remove the script and instead run dest/node/main.js directly to use the bb.js binary

@kevaundray
Copy link
Contributor Author

pinging @jonybur for visibility

@iAmMichaelConnor iAmMichaelConnor added the C-bb.js Component: bb.js - wrapping bberg in js label Aug 20, 2023
@kevaundray
Copy link
Contributor Author

Closing as this was noted to be okay

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 20, 2023
codygunton pushed a commit that referenced this issue Jan 23, 2024
* Copied index.html to output (#1661)

* Generate htnl file (#1662)

* Deployment fix (#1663)

* Deployment fixes (#1665)

* Deployment fix attempt (#1667)

* Updated falafel and kebab terraform with new project directory structure (#1670)

* Reduce the amount of logging in kebab (#1668)

* Reduce the amount of logging in kebab

* Logging improvement

* Bug fix

* Reverted erroneous change

* Pw/increase faucet drip (#1669)

* Increased the faucet drip size

* Force contract redeployment

* Deploy terraform from correct directory (#1671)

* JB/Website grants updates (#1666)

* Add new grant

* Improve research images

* Mini typo

* JB/Website build manifest (#1672)

* Add website to build manifest

* JB/Brand iteration (#1673)

* Small build change

* JB/Fix website deployment (#1676)

* Fix deployment

* JB/Fix website deploy (#1677)

* Fix deploy

Co-authored-by: Jonathan Bursztyn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bb.js Component: bb.js - wrapping bberg in js
Projects
Archived in project
Development

No branches or pull requests

3 participants