Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bb-bin-tests not rebuilding when ts folder is changed #1665

Open
kevaundray opened this issue Aug 18, 2023 · 1 comment
Open

bb-bin-tests not rebuilding when ts folder is changed #1665

kevaundray opened this issue Aug 18, 2023 · 1 comment
Labels
A-devops Area: Devops. E.g. CI / build systems C-bb.js Component: bb.js - wrapping bberg in js

Comments

@kevaundray
Copy link
Contributor

This is a retroactive issue. The PR has been made here

Problem

The bb-bin-tests are testing the cli version of our typescript code, formally known as bb.js. The build-system was not including the typescript folder as part of the rebuild pattern, so changes to the typescript folder would not trigger the bb-bin-tests to run.

Partial Solution

Since bb.js is always rebuilt in the CI when the typescript folder changes, we can run the bb-bin-test there.

This is what the linked PR is doing, but its not ideal because there are two other jobs which wait for bb.js to build before running its tests; bb-js-test and barretenberg-acir-tests.

Ideal Solution

bb-bin-test is a separate job which relies on the build step of bb.js.

This was attempted however we settled on the less than ideal solution above, given that these tests are only ran when barretenberg or the typescript folder changes.
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 18, 2023
@kevaundray kevaundray added the A-devops Area: Devops. E.g. CI / build systems label Aug 18, 2023
@kevaundray
Copy link
Contributor Author

Leaving this open as we would want the ideal solution

@Maddiaa0 Maddiaa0 mentioned this issue Aug 18, 2023
Merged
4 tasks
@iAmMichaelConnor iAmMichaelConnor added the C-bb.js Component: bb.js - wrapping bberg in js label Aug 20, 2023
codygunton pushed a commit that referenced this issue Jan 23, 2024
@PhilWindle @jonybur
Merge pull request #1678 from AztecProtocol/defi-bridge-project
40476bb 
* Copied index.html to output (#1661)

* Generate htnl file (#1662)

* Deployment fix (#1663)

* Deployment fixes (#1665)

* Deployment fix attempt (#1667)

* Updated falafel and kebab terraform with new project directory structure (#1670)

* Reduce the amount of logging in kebab (#1668)

* Reduce the amount of logging in kebab

* Logging improvement

* Bug fix

* Reverted erroneous change

* Pw/increase faucet drip (#1669)

* Increased the faucet drip size

* Force contract redeployment

* Deploy terraform from correct directory (#1671)

* JB/Website grants updates (#1666)

* Add new grant

* Improve research images

* Mini typo

* JB/Website build manifest (#1672)

* Add website to build manifest

* JB/Brand iteration (#1673)

* Small build change

* JB/Fix website deployment (#1676)

* Fix deployment

* JB/Fix website deploy (#1677)

* Fix deploy

Co-authored-by: Jonathan Bursztyn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-devops Area: Devops. E.g. CI / build systems C-bb.js Component: bb.js - wrapping bberg in js
Projects
A3
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevaundray @iAmMichaelConnor