feat: CompleteAddress type
#1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesjan
force-pushed
the
janb/complete-address-type
branch
3 times, most recently
from
820c72b to
a39a74e
Compare
PhilWindle
previously approved these changes
Aug 11, 2023
PhilWindle
previously requested changes
Aug 12, 2023
benesjan
force-pushed
the
janb/complete-address-type
branch
2 times, most recently
from
7e91992 to
6a9cf25
Compare
benesjan
force-pushed
the
janb/complete-address-type
branch
from
6a9cf25 to
9577cc7
Compare
benesjan
force-pushed
the
janb/complete-address-type
branch
from
2f90170 to
d15bfcf
Compare
spalladino
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Wow, this was a massive change, thanks for taking it on @benesjan! And yeah, the resulting code is a lot cleaner.
Comment on lines
+86
to
+89
| // TODO: Re-enable this check once https://github.com/AztecProtocol/aztec-packages/issues/1556 is solved | ||
| // if (!pubKey.equals(account.publicKey)) { | ||
| // throw new Error(`Public key mismatch: ${pubKey.toString()} != ${account.publicKey.toString()}`); | ||
| // } |
There was a problem hiding this comment.
Note that this was re-enabled on master
benesjan
dismissed
PhilWindle’s stale review
Docs were already updated and Phil is on vacations so I need to dismiss this to be able to merge the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PartialAddress,PublicKeyandAztecAddress#1516addAccountapi as Aztec CLI command #1527e2e_aztec_js_browser.Note: When implementing this PR I've stumbled upon this issue. I would wait for @spypsy to come back before dealing with this since he's the most knowledgeable about that part of codebase.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.