JsonRpcServer does not return a proper class instance but only an object with its properties
#1556
Labels
T-bug
Type: Bug. Something is broken.
Milestone
Comments
benesjan
changed the title
JsonRpcServer does not return a proper class instance but only an object with its properties
|
@benesjan Can you give more information around this one please? What was the problem you faced? Do we need to do this before the sandbox is released? This object is designed to just proxy calls to the real rpc server. |
PhilWindle
pushed a commit
that referenced
this issue
Aug 22, 2023
I tried reproducing #1556 issue but it doesn't seem to occur anymore. For this reason the pubkey check can be re-enabled. Fixes #1556 # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
|
@PhilWindle the issue doesn't seem to occur anymore so I re-enabled the check in this PR and we can close this issue. |
codygunton
pushed a commit
that referenced
this issue
Jan 23, 2024
* Initial attempt to have Kebab perform deployments (#1558) * Initial attempt to have Kebab perform deployments * Fix e2e tests, don't redeploy if given rollup contract * Use correct verification key * Bug fix * VK fix * Added curl to Falafel docker image * WIP * WIP * Updated Faucet * WIP * Deploy mainnet fork alongside kebab (#1556) * Deploy mainnet fork alongside kebab * Added backend block * Updated kebab TF Co-authored-by: PhilWindle <[email protected]> * WIP * Fixed env var name * WIP * Yarn lock files * Revert explorer and zk-money changes * Use devnet specific private key * Additional logging * Attempt to fix block explorer * Reverted unnecessary change * Fix bigint literals and remove hosted sdk e2e test * Fixes Co-authored-by: spypsy <[email protected]> * Fixed command ordering (#1566) * Fixed scripting (#1567) * More TF fixes (#1571) * Force contract redeploy (dev) (#1568) * force contract redeploy + add port to kebab health check * undo port specification for healthcheck * Log the number of drips provided by the faucet (#1518) * Pw/devnet deployment fixes (#1574) * Terraform changes to restart Falafel and Faucet on redeployment * New Devnet chain id * Fix pkey srs size to (n + 1) while loading a pkey. (#1550) * Pw/devnet deployment fixes (#1577) * Terraform changes to restart Falafel and Faucet on redeployment * New Devnet chain id * Fixed Falafel Dev Terraform * Fixed Faucet Dev Terraform (#1578) * Updated Wasabi Terraform for Dev and Test nets (#1579) * Fix for Wasabi Uniswap Terraform (#1580) * update JSON provider request method (#1588) * update JSON provider request method * comment clarification * allow additional methods to go through kebab auth (#1589) * Allow for setting of Rollup Provider in deployments (#1590) * Allow for setting of Rollup Provider in deployments * Force contract redeployment * Terraform fix * Pw/testnet deployment (#1591) * WIP * WIP * WIP * TF updates * Dev TF fix Co-authored-by: spypsy <[email protected]> Co-authored-by: Suyash Bagad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This caused an issue here when running
e2e_aztec_js_browser.test.ts.The text was updated successfully, but these errors were encountered: