Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open editor form error list #355

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Open editor form error list #355

merged 3 commits into from
Aug 3, 2023

Conversation

workgroupengineering
Copy link
Contributor

@workgroupengineering
Copy link
Contributor Author

@emmauss When you have spare time, can you test this?

@emmauss
Copy link

emmauss commented Jul 6, 2023 •
edited
Loading

@emmauss When you have spare time, can you test this?

I'm unable to install your extension. If you want feedback on the issue I reported previously, as long as you can open .xaml files, then the issue is resolved.

@Takoooooo
Copy link
Contributor

I can't find any difference between master and this PR,designer doesen't open for me when i click on the error in the list. Does it work for you?

@workgroupengineering
Copy link
Contributor Author

I can't find any difference between master and this PR,designer doesen't open for me when i click on the error in the list. Does it work for you?

With this PR on my machine it works as expected.

@Takoooooo
Copy link
Contributor

May you make a gif of how it should work? Maybe i am testing something incorrectly

@workgroupengineering
Copy link
Contributor Author

Yes, but now i am out of office.

@workgroupengineering
Copy link
Contributor Author

Before

Before

After

After

Test Project

ACTest.zip

Takoooooo
Takoooooo approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@Takoooooo Takoooooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for me,thanks!

@Takoooooo Takoooooo enabled auto-merge August 3, 2023 14:34
@Takoooooo Takoooooo merged commit 4fde0f2 into AvaloniaUI:master Aug 3, 2023
@workgroupengineering workgroupengineering deleted the features/Open_Editor_form_ErrorList branch August 3, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Takoooooo Takoooooo Takoooooo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Previewer no longer treats .xaml files as design files
3 participants
@workgroupengineering @emmauss @Takoooooo