Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Open Avalonia Xaml Designer on double-clicking on Errors list #321

Conversation

workgroupengineering
Copy link
Contributor

Current behavior:

When double-clicking the error list entry, XML Designer opens instead of Avalonia Xaml Designer

Expected behavior

When double-clicking the error list entry, XML Designer opens

How simulate issue:

  1. Create new Avalonia Project
  2. Add Resource Dictionary named `icons.axaml'
  3. Edit App.axaml like this
<Application xmlns="https://github.com/avaloniaui"
           xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
           xmlns:local="using:ACTest"
           x:Class="ACTest.App">
  <Application.DataTemplates>
      <local:ViewLocator/>
  </Application.DataTemplates>

  <Application.Resources>
 	 <ResourceDictionary>
 		 <ResourceDictionary.MergedDictionaries>
 			 <ResourceInclude Source="Icons.axaml" />
 		 </ResourceDictionary.MergedDictionaries>
 	 </ResourceDictionary>
 </Application.Resources>
 
  <Application.Styles>
      <FluentTheme/>
  </Application.Styles>
</Application>
  1. You can see in Errors list error like this:

    Severity Code Description Project File Line Suppression State
    Error Unable to resolve XAML resource "avares://ACTest/Designer/Icons.axaml" in the "ACTest" assembly. Line 12, position 22. ACTest .\ACTest\ACTest\App.axaml 12
  2. do double-clicking

  3. XML Designer will open

@maxkatz6
Copy link
Member

Expected behavior
When double-clicking the error list entry, XML Designer opens

I think you meant "XAML designer", right?

@maxkatz6 maxkatz6 merged commit c29121f into AvaloniaUI:master Mar 17, 2023
@workgroupengineering workgroupengineering deleted the fixes/Open_Editor_form_ErrorList branch March 17, 2023 07:42
Takoooooo added a commit that referenced this pull request Jun 20, 2023
@Takoooooo Takoooooo mentioned this pull request Jun 20, 2023
Takoooooo added a commit that referenced this pull request Jun 20, 2023
workgroupengineering added a commit to workgroupengineering/AvaloniaVS that referenced this pull request Jul 6, 2023
This reverts commit 53004a1.
workgroupengineering added a commit to workgroupengineering/AvaloniaVS that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants