Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DesktopRuntime project and move AppBuilder to PlatformSupport project #7677

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Remove DesktopRuntime project and move AppBuilder to PlatformSupport project #7677

merged 1 commit into from
Feb 22, 2022

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented Feb 22, 2022 •
edited
Loading

What is the current behavior?

  1. AppBuilder is not available in netstandard2.0 based backends (legacy xamarin).
  2. Legacy "UseSubsystemsFromStartupDirectory" is available and doesn't work properly with .net core.

What is the updated/expected behavior with this PR?

  1. AppBuilder is moved to PlatformSupport project (net6 + netstandard + net46)
  2. DesktopRuntime project is removed
  3. UseSubsystemsFromStartupDirectory feature is removed

Fixes #7052

@maxkatz6 maxkatz6 merged commit 0a2b650 into master Feb 22, 2022
@maxkatz6 maxkatz6 deleted the cleanup/move-appbuilder-class branch February 22, 2022 23:54
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 0.10.999-cibuild0018898-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees
No one assigned
Labels
breaking-change wont-backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move AppBuilder to netstandard2.0 library
3 participants
@maxkatz6 @avaloniaui-team @jkoritzinsky