Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AppBuilder to netstandard2.0 library #7052

Closed
kekekeks opened this issue Dec 1, 2021 · 1 comment · Fixed by #7677
Closed

Move AppBuilder to netstandard2.0 library #7052

kekekeks opened this issue Dec 1, 2021 · 1 comment · Fixed by #7677

Comments

@kekekeks
Copy link
Member

kekekeks commented Dec 1, 2021

During the PCL and netstandard1.x eras certain APIs were only available when targeting "full" runtimes (.NET 4.x, .NET Core, Xamarin.Android, Xamarin.iOS). So we've had those in shared code and compiled them into libraries targeting those "full" runtimes while having AppBuilderBase in our PCL/netstandard1.1/netstandard1.3 library. That continued for a while, so we now have several #if blocks in that shared code. We should replace those #ifs with IsOSPlatform checks before moving AppBuilder to netstandard2.0.

@maxkatz6
Copy link
Member

maxkatz6 commented Dec 1, 2021

I already did it for my android/ios sdk PR locally, need to cleanup and push to a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants