Search all SelectingItemsControl items with TextSearch on key input, not just realized ones #17506
+68
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonko0493
changed the title
|
You can test this PR using the following package version. |
|
|
@cla-avalonia agree |
|
Everything was passing prior to me merging master... not sure what changed, could be transient failures? |
|
@jonko0493 don't worry tests are a bit flaky atm |
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR brings the behavior of
SelectingItemControls withVirtualizingPanelpresenters into parity with those controls without virtualizing presenters.What is the current behavior?
Currently,
SelectingItemsControls withVirtualizingPanelitem presenters (such asComboBox) do not search the full contents of their boxes with text search, only the currently realized controls. This meansthat if a(this was slightly wrong!) it will only jump to items immediately in the popup.ComboBoxis closed, typing does nothing, and even when opened,What is the updated/expected behavior with this PR?
Now,
ComboBoxes and otherSelectingItemsControls with virtualizing presenters will have properTextSearchfor their entire item sets.How was the solution implemented (if it's not obvious)?
The anonymous method that existed in the
SelectingItemsControlclass previously has been moved into a static method inItemsPresenter. It's now used there and inVirtualizingPanelto check search their items/children for text search. (Note: I don't know if there is a preferred place for a static method like this; happy to move as appropriate.)Unit test case was added to an existing test and the test was adapted so that ComboBoxes in tests will use a
VirtualizingStackPanellike the real controls do to ensure the tests fail without this change.Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #12490.