[SelectingItemsControl] TextSearch in all items, not only realized items

[dbriard]

It is a bit strange to me that the ComboBox and SelectingItemsControl only search in realized items, why not to search in all items?

Use case is Font ComboBox with 1000+ Google Fonts.

Quick solution:

• Could also be an interface to implement by the items to return the TextSearch's Text instead of ToString().
• Or an event in ComboBox to implement to select the desired item according to search term.
  I am not sure what is the best way.

As EditableComboBox do not exists in Avalonia, that improvement would be appreciated as a workaround. Thank you.

[timunie]

Iirc in WPF there is TextSearchPath which we may want to port to Avalonia. https://learn.microsoft.com/en-us/dotnet/api/system.windows.controls.textsearch?view=windowsdesktop-7.0

[ElliotEserinUT]

Sorry, if I wanted to implement this quick solution, is there an easy way to do it? inheriting from combo box or something or would I have to fork the repo and change the SelectingItemsControl?

[jonko0493]

@ElliotEserinUT perhaps a little late to the party, but there is a workaround to do this for now. I've implemented it in this PR: https://github.com/haroohie-club/SerialLoops/pull/419/files#diff-3cbf4d5441529ea6762800fb2e7b1bcc8460f093147edadfca4cf8931e3e05e6R26-R30

[ElliotEserinUT]

@ElliotEserinUT perhaps a little late to the party, but there is a workaround to do this for now. I've implemented it in this PR: https://github.com/haroohie-club/SerialLoops/pull/419/files#diff-3cbf4d5441529ea6762800fb2e7b1bcc8460f093147edadfca4cf8931e3e05e6R26-R30

That's great, thank you 😁 I did end up figuring out how to override the base function to make it work, but it definitely needs fixing and I'm sure I'll need this again so it's greatly appreciated!

[jonko0493]

@ElliotEserinUT just realized that my solution does not actually fix this issue, so I filed #17506 to implement it properly!