Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transform desync #16363

Merged
merged 11 commits into from
Sep 12, 2024
Merged

Conversation

Gillibald
Copy link
Contributor

@Gillibald Gillibald commented Jul 18, 2024

What does the pull request do?

This PR makes sure the platform drawing context always has the same total matrix as the drawing context wrapper. Otherwise, some drawing operations might see the wrong total matrix.

It is unknown why this happens

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes: #16337
Fixes: #16610

@kekekeks kekekeks self-requested a review July 18, 2024 10:23
@kekekeks kekekeks self-assigned this Jul 18, 2024
@kekekeks
Copy link
Member

Could you add a render test?

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050262-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Gillibald
Copy link
Contributor Author

@kekekeks I added some tests. At first, I tried to add some cross-tests but couldn't reproduce the issue. Then I added the original sample as a render test and the issue showed up.

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050596-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Gillibald Gillibald changed the title [WIP] Fix transform desync Fix transform desync Jul 30, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050955-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added the bug label Sep 12, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0051785-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Gillibald Gillibald added this pull request to the merge queue Sep 12, 2024
Merged via the queue into AvaloniaUI:master with commit 7da58ba Sep 12, 2024
11 checks passed
@Gillibald Gillibald deleted the fixes/transformDesync branch September 12, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DrawingContext state is broken in some cases DrawingContext has a mess in state management in 11.1.0-rc2.
4 participants