Don't merge RenderOptions during update and only push them to drawing context if actually needed #15111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Mar 25, 2024
maxkatz6
reviewed
Mar 25, 2024
src/Avalonia.Base/Rendering/Composition/Server/ServerCompositionVisual.cs
Show resolved
Hide resolved
kekekeks
force-pushed
the
feature/perf-2024-03-0004
branch
from
426128d to
1cfbddc
Compare
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.1.x
maxkatz6
pushed a commit
that referenced
this pull request
Apr 24, 2024
… context if actually needed (#15111) * Don't merge RenderOptions during update and only push them to drawing context if actually needed * Removed RenderOptions property from IDrawingContextImpl #Conflicts: # src/Skia/Avalonia.Skia/DrawingContextImpl.cs
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed direct RenderOptions setter from IDrawingContextImpl, since we are supposed to use Push/Pop.
Yet another nit I've discovered during profiling