Use a separate LtrbRect type for render calculations #15112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kekekeks
force-pushed
the
feature/perf-2024-03-0005
branch
from
99fe3f2 to
2d4825f
Compare
kekekeks
changed the title
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Mar 28, 2024
maxkatz6
added
the
backport-candidate-11.1.x
maxkatz6
pushed a commit
that referenced
this pull request
Apr 24, 2024
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are doing quite a lot of Union/Intersect/Intersects operations in the renderer and those operate with Left/Top/Right/Bottom properties.
Our Rect type doesn't store Right/Bottom and has Width/Height instead, so there are lots of conversions. Render frame went from 26.5ms to 25.0ms on a "lots of controls on a canvas" benchmark, so the perf gain is significant enough to justify having a separate type.