Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13463 AutoCompleteBox should have a bindable Property for CaretIndex #13851

Merged

Conversation

RobertMut
Copy link
Contributor

What does the pull request do?

Adds caret index property to autocompletebox as discussed in #13423

What is the current behavior?

There's needed workaround, otherwise caret index can't be changed/read.

What is the updated/expected behavior with this PR?

You can modify TextBox's caret index position from AutoCompleteBox property or vice versa

How was the solution implemented (if it's not obvious)?

Adds AutoCompleteBox owner to registered CaretIndex TextBox property, also adds template binding to theme xaml files.

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #13463

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0042702-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Copy link
Member

@jmacato jmacato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmacato jmacato added this pull request to the merge queue Dec 6, 2023
Merged via the queue into AvaloniaUI:master with commit 8a4c89f Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoCompleteBox should have a bindable Property for CaretIndex
3 participants