Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly Ordered Character Input in AutoCompleteBox #14216

Closed
robloo opened this issue Jan 16, 2024 · 4 comments · Fixed by #14264
Closed

Incorrectly Ordered Character Input in AutoCompleteBox #14216

robloo opened this issue Jan 16, 2024 · 4 comments · Fixed by #14264
Labels
bug help-wanted A contribution from the community would be most welcome. regression

Comments

@robloo
Copy link
Contributor

robloo commented Jan 16, 2024

Describe the bug

AutoCompleteBox text input is broken in a rather severe way. Typed characters are incorrectly ordered.

To Reproduce

Steps to reproduce the behavior:

  1. Type first character
  2. Type second character
  3. Note the cursor moves to the wrong position...
  4. Type third character, it's in the wrong position

Expected behavior

Normal text input

Screenshots

issue

Environment

  • OS: Windows 10 Pro 22H2
  • Avalonia-Version: 11.0.6+ (36e7ab5)

Additional context

The PR #13851 likely broke this. cc @RobertMut

@robloo
Copy link
Contributor Author

robloo commented Jan 17, 2024

There are issues with selection as well it seems.

I think we should consider reverting the related PRs before the next release. These issues make AutoCompleteBox unusable.

@maxkatz6
Copy link
Member

Original PR wasn't backported to 11.0, so we have a bit more time.

@maxkatz6 maxkatz6 added the help-wanted A contribution from the community would be most welcome. label Jan 17, 2024
@RobertMut
Copy link
Contributor

Hi, thanks for mentioning.
I've opened a pull request #14264 with a fix. By the accident I added CoerceCaretIndex to CaretIndexProperty in AutoCompleteBox, which caused this weird behaviour, if I understand correctly.
Sorry for causing trouble!

@timunie
Copy link
Contributor

timunie commented Jan 19, 2024

Sorry for causing trouble!

@RobertMut don't worry, we appreciate your contributions and also your sense of fixing things introduced by accident ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help-wanted A contribution from the community would be most welcome. regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants