Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sites Dashboard: Remove the max-width for the banner #96764

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

okmttdhr
Copy link
Member

@okmttdhr okmttdhr commented Nov 26, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/9915

Proposed Changes

This PR is a follow-up for #96713 (comment).

Screenshot 2024-11-26 at 15 36 17

Why are these changes being made?

pbxlJb-6DF-p2

Testing Instructions

  • Comment out this line to show the banner on your local Calypso. (I wasn't sure how to show the banner.)
  • Go to /sites
  • Observe the banner is aligned with the "Sites" and DataView.
    • in the large view > 1440px
    • in the mobile view (especially > 430px)

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@okmttdhr okmttdhr force-pushed the fix/max-width-banner branch from 30d2f7c to f4f77c5 Compare November 26, 2024 06:34
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@okmttdhr okmttdhr marked this pull request as ready for review November 26, 2024 06:39
@okmttdhr okmttdhr requested a review from a team November 26, 2024 06:39
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 26, 2024
Comment on lines +71 to +76
// To align with Core's hard-coded device width.
// https://github.com/WordPress/gutenberg/blob/ed66cc50e3c0b6785a48c15230c090790c0b0e6c/packages/dataviews/src/components/dataviews/style.scss#L84
// TODO: Remove when Core changes to use one of the predefined breakpoints.
@media (max-width: 430px) {
padding-inline: 24px;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oandregal
This 430px is derived from Core. Would it make sense to update it to $break-mobile: 480px;? If so, I’m happy to create a PR.

Copy link
Contributor

@oandregal oandregal Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I know is that it was introduced as part of this PR (and then the code was moved around, so it was a bit difficult to track). I'll defer this one to designers. Can you raise this to them?

Copy link
Member Author

@okmttdhr okmttdhr Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look at it! Left a comment for now: WordPress/gutenberg#61333 (comment)

@okmttdhr okmttdhr requested a review from oandregal November 26, 2024 06:42
@okmttdhr okmttdhr self-assigned this Nov 26, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/max-width-banner on your sandbox.

Copy link
Contributor

@madhusudhand madhusudhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the banner in different viewports. It is set to the right width and matches sites header and dataview actions.

@okmttdhr okmttdhr merged commit ce5b92e into trunk Nov 27, 2024
17 of 18 checks passed
@okmttdhr okmttdhr deleted the fix/max-width-banner branch November 27, 2024 02:12
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants