-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sites Dashboard: Remove the max-width for the banner #96764
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
30d2f7c
to
f4f77c5
Compare
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
// To align with Core's hard-coded device width. | ||
// https://github.com/WordPress/gutenberg/blob/ed66cc50e3c0b6785a48c15230c090790c0b0e6c/packages/dataviews/src/components/dataviews/style.scss#L84 | ||
// TODO: Remove when Core changes to use one of the predefined breakpoints. | ||
@media (max-width: 430px) { | ||
padding-inline: 24px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oandregal
This 430px
is derived from Core. Would it make sense to update it to $break-mobile: 480px;
? If so, I’m happy to create a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I know is that it was introduced as part of this PR (and then the code was moved around, so it was a bit difficult to track). I'll defer this one to designers. Can you raise this to them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look at it! Left a comment for now: WordPress/gutenberg#61333 (comment)
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified the banner in different viewports. It is set to the right width and matches sites header and dataview actions.
Related to https://github.com/Automattic/dotcom-forge/issues/9915
Proposed Changes
This PR is a follow-up for #96713 (comment).
Why are these changes being made?
pbxlJb-6DF-p2
Testing Instructions
Pre-merge Checklist