Skip to content

Commit

Permalink
Remove the max-width for the banner
Browse files Browse the repository at this point in the history
  • Loading branch information
okmttdhr committed Nov 26, 2024
1 parent 691bfd9 commit 30d2f7c
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 25 deletions.
25 changes: 0 additions & 25 deletions client/sites/components/dotcom-style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,6 @@
}

.wpcom-site .main.a4a-layout.sites-dashboard {
.a4a-layout__top-wrapper,
.a4a-layout__body {
> * {
padding-inline: 48px;
// Override the max-width set in a8c-for-agencies/components/layout/style.scss
// as the title aligns with DataViews (full width).
max-width: revert;
@media (max-width: 402px) {
padding-inline: 24px;
}
}
}

.a4a-layout__header {
align-items: center;
}
Expand Down Expand Up @@ -83,10 +70,6 @@
@media (max-width: 402px) {
padding-inline: 24px;
}

@include break-huge {
max-width: 1400px;
}
}

.sites-banner {
Expand Down Expand Up @@ -380,14 +363,6 @@
}
}

.wpcom-site .main.a4a-layout.sites-dashboard.sites-dashboard__layout.preview-hidden {
div.a4a-layout__viewport {
// margin: 0 auto;
// max-width: 1400px;
// box-sizing: border-box;
}
}

// Use flexbox to structure of fly-out panel.
.wpcom-site .main.a4a-layout.sites-dashboard.sites-dashboard__layout:not(.preview-hidden) {
&.a4a-layout,
Expand Down
21 changes: 21 additions & 0 deletions client/sites/components/sites-dataviews/dataview-style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,25 @@
}
}
}
}

.wpcom-site .main.a4a-layout.sites-dashboard {
.a4a-layout__top-wrapper,
.a4a-layout__body {
> * {
padding-inline: 48px;

// Override the max-width set in a8c-for-agencies/components/layout/style.scss
// as the title aligns with DataViews (full width).
// TODO: Remove when we drop A4A Layout or when A4A Layout drops the max-width.
max-width: revert;

// To align with Core's hard-coded device width.
// https://github.com/WordPress/gutenberg/blob/ed66cc50e3c0b6785a48c15230c090790c0b0e6c/packages/dataviews/src/components/dataviews/style.scss#L84
// TODO: Remove when Core changes to use one of the predefined breakpoints.
@media (max-width: 430px) {
padding-inline: 24px;
}
}
}
}

0 comments on commit 30d2f7c

Please sign in to comment.