Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display color schemes in alphabetical order #47342

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Display color schemes in alphabetical order #47342

merged 1 commit into from
Nov 12, 2020

Conversation

mreishus
Copy link
Contributor

Changes proposed in this Pull Request

  • Color scheme order on /me/account is alphabetical.

Testing instructions

Testing instructions

  • Visit /me/account
  • See the color scheme order
    2020-11-11_15-24

Reference Issues

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/alphabetize-color-schemes

@mreishus mreishus self-assigned this Nov 11, 2020
@mreishus mreishus added the [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. label Nov 11, 2020
@mreishus mreishus requested a review from a team November 11, 2020 21:24
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 11, 2020
@mreishus mreishus mentioned this pull request Nov 11, 2020
Closed
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

cpapazoglou
cpapazoglou approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@cpapazoglou cpapazoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cpapazoglou cpapazoglou merged commit a968f2a into master Nov 12, 2020
@cpapazoglou cpapazoglou deleted the fix/alphabetize-color-schemes branch November 12, 2020 10:32
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpapazoglou cpapazoglou cpapazoglou approved these changes

Assignees

@mreishus mreishus

Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mreishus @matticbot @cpapazoglou