-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Randomize color scheme order #47304
Randomize color scheme order #47304
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Webpack Runtime (~24 bytes added 📈 [gzipped])
Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded. App Entrypoints (~2 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~408 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~220 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested as per testing instructions and the color schemes feature behaved the following way:
When navigating to /me/account, then navigating somewhere else on the site without a reload, then navigating to /me/account again, the selection stayed the same. When navigating to /me/account and then reloading the same page, the selection got shuffled around. I assume this is the wanted behavior, right?
Aside: I understand the idea that it'll help make tracking data less dependent on the order of the color schemes but I'm personally not sure this leads to a better user experience. That's just my personal opinion though, it's up to design/product to decide what's best for the user.
One thing I did notice is that we might have lost the translations in the process? See:
Production | This branch |
---|---|
Ok, since the dependency injection fix didn't work, I'm abandoning this. |
#47342 Display in alphabetical order |
Changes proposed in this Pull Request
/me/account
is randomized.shuffle()
call changed the order every time you clicked, with hilarious results.translation
dependency injection while randomizing a list such that it doesn't change every time you click.Testing instructions
/me/account
Reference Issues