CI: Remove tsc caching from circleci #39962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
scinos
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Build: Speed up
tscbuilds #38903 added TypeScript caching, but didn't do it correctly on CircleCIBuild: Composite TypeScript setup #39786 Attempted to fix TypeScript caching, but introduced a bug. It relied on a glob in the cache path which is unavailable (
packages/*/dist):https://circleci.com/docs/2.0/caching/#basic-example-of-dependency-caching
The result is that the cache files (tsbuildinfo) are cached, but the generated output is not. This results in
tscnot generating any output, similar to #39960.Remove the tsc caching, which would require listing out the type output path for each package in the CircleCI configuration.
Testing instructions
The
typecheck-strictjob should be fixed. Currently broken in #39960