Build: Clean tsbuildinfo files on package clean #39960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
added
[Type] Bug
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
sirreal
force-pushed
the
update/clean-tsbuildinfo
branch
from
1298f3e to
4dbe19d
Compare
|
#39962 should fix the |
If these files are not cleaned, tsc will skip work even if declaration files are missing and need to be generated. Ensure that with package clean, the tsbuildinfo files are also removed.
sirreal
force-pushed
the
update/clean-tsbuildinfo
branch
from
4dbe19d to
cfd6a23
Compare
|
Rebased, job failure should be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If tsbuildinfo (TypeScript cache) files are not cleaned,
tscwill skip work even if declarationfiles are missing and need to be generated.
Ensure that with package clean, the tsbuildinfo files are also removed.
Follow up to #39786
Testing instructions
When running this sequence of commands, tsbuildinfo files must be removed with generated types or they will not be regenterated.
On master, the following will error with missing types. On this branch is succeeds because the tsbuildinfo are removed which forces regeneration of declaration files.