Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIWA: Make sure we have sent the apple user info to the server before redirecting #37371

Merged
merged 3 commits into from
Nov 7, 2019

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Nov 6, 2019

Initial attempt was reverted (before hitting production) as nginx isn't actually configured to forward /sign-in/apple/callback to calypso
Update: we don't need to deploy that change as /log-in/apple/callback is now whitelisted

Changes proposed in this Pull Request

  • This PR updates how we parse the JSON user object coming from apple as there seems to have been some changes around this.
  • It also refactors the sign in with apple server side code and makes sure the usersSocialNew request is completed before redirecting the user

Testing instructions

@Tug Tug requested a review from a team as a code owner November 6, 2019 20:32
@Tug Tug self-assigned this Nov 6, 2019
@matticbot
Copy link
Contributor

@Tug Tug changed the title SIWA: Update the login return uri (take 2) SIWA: Make sure we have sent the apple user info to the server before redirecting Nov 7, 2019
@Tug Tug added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Nov 7, 2019
@Tug Tug requested a review from astralbodies November 7, 2019 13:31
@matticbot
Copy link
Contributor

matticbot commented Nov 7, 2019

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~20 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
security        +63 B  (+0.0%)      +20 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@Tug Tug requested a review from nsakaimbo November 7, 2019 16:26
Copy link
Contributor

@nsakaimbo nsakaimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired with @Tug to test these changes, confirmed this patch is working as expected. LGTM.

@Tug Tug merged commit 1769e6e into master Nov 7, 2019
@Tug Tug deleted the update/siwa-change-login-return-url branch November 7, 2019 17:00
@Tug
Copy link
Contributor Author

Tug commented Nov 7, 2019

Thanks @nsakaimbo :)

@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants