Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIWA: Update the login return uri #37353

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Nov 6, 2019

Changes proposed in this Pull Request

  • This PR updates the login return url for sign in with apple from POST /log-in/apple/callback to POST /sign-in/apple/callback.
  • It also updates how we parse the JSON user object coming from apple as there seems to have been some changes around this.

Testing instructions

Fixes #37336

@Tug Tug requested a review from a team as a code owner November 6, 2019 10:10
@Tug Tug self-assigned this Nov 6, 2019
@matticbot
Copy link
Contributor

@Tug Tug requested review from tyxla, pento and astralbodies November 6, 2019 10:17
@Tug Tug added Login [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 6, 2019
@matticbot
Copy link
Contributor

matticbot commented Nov 6, 2019

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~59 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
entry-main         +65 B  (+0.0%)      +30 B  (+0.0%)
entry-login        +65 B  (+0.0%)      +29 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@Tug Tug force-pushed the update/siwa-change-login-return-url branch from 4dfdbdf to 48bb894 Compare November 6, 2019 10:30
@Tug Tug requested a review from belcherj November 6, 2019 10:32
Copy link
Contributor

@astralbodies astralbodies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work for me! I'm having some strange issues with Charles that's not getting me to a logged-in state though after it redirects.

@Tug Tug merged commit 8ceaf3b into master Nov 6, 2019
@Tug Tug deleted the update/siwa-change-login-return-url branch November 6, 2019 20:06
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 6, 2019
Tug added a commit that referenced this pull request Nov 6, 2019
… is blacklisted by our servers (#37353)"

This reverts commit 8ceaf3b.
Tug added a commit that referenced this pull request Nov 6, 2019
… is blacklisted by our servers (#37353)" (#37369)

This reverts commit 8ceaf3b.
@Tug Tug restored the update/siwa-change-login-return-url branch November 6, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social Login: Sign in with Apple returns 405 error
3 participants