Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composite-checkout: add initial tests #36744

Merged
merged 1 commit into from
Oct 28, 2019
Merged

composite-checkout: add initial tests #36744

merged 1 commit into from
Oct 28, 2019

Conversation

nbloomf
Copy link
Contributor

@nbloomf nbloomf commented Oct 14, 2019 •
edited
Loading

Changes proposed in this Pull Request

This adds @testing-library/react and @testing-library/jest-dom as dev dependencies.

Testing instructions

npm install && npm run test-packages composite-checkout

@nbloomf nbloomf requested a review from a team as a code owner October 14, 2019 20:13
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/wp-checkout-component-test

@nbloomf nbloomf requested a review from sirbrillig October 14, 2019 20:13
@nbloomf nbloomf mentioned this pull request Oct 14, 2019
Closed
@matticbot
Copy link
Contributor

matticbot commented Oct 14, 2019 •
edited
Loading

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirbrillig
Copy link
Member

Might be good to change the title of this PR to fit the general title scheme of calypso PRs. Typically `Section or Project: declarative summary". In this case maybe something like "wp-checkout: add initial tests"

@nbloomf nbloomf changed the title Add/wp checkout component test wp-checkout: add initial tests Oct 14, 2019
@nbloomf nbloomf force-pushed the add/wp-checkout-component-test branch from 81cadd8 to e1ddf84 Compare October 14, 2019 22:04
@nbloomf nbloomf mentioned this pull request Oct 15, 2019
Open
@sirbrillig sirbrillig force-pushed the add/wp-checkout-component branch 3 times, most recently from 184b1a9 to 35ba4cd Compare October 18, 2019 15:04
@nbloomf nbloomf force-pushed the add/wp-checkout-component-test branch 2 times, most recently from 55453d3 to 349e43b Compare October 22, 2019 21:40
@nbloomf nbloomf requested a review from a team as a code owner October 22, 2019 21:40
@nbloomf nbloomf changed the base branch from add/wp-checkout-component to master October 22, 2019 21:41
@nbloomf nbloomf changed the title wp-checkout: add initial tests composite-checkout: add initial tests Oct 22, 2019
sirbrillig
sirbrillig approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@sirbrillig sirbrillig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added testing instructions to the description and suggested one change with the test wording, but otherwise good to go.

@nbloomf nbloomf force-pushed the add/wp-checkout-component-test branch from 0ff35cf to e8e54fb Compare October 25, 2019 15:58
@nbloomf nbloomf force-pushed the add/wp-checkout-component-test branch from 1f3aaf3 to fa818a7 Compare October 25, 2019 21:27
sirbrillig
sirbrillig approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@sirbrillig sirbrillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great. Nice work!

@nbloomf nbloomf merged commit 5aeaf1a into master Oct 28, 2019
@nbloomf nbloomf deleted the add/wp-checkout-component-test branch October 28, 2019 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirbrillig sirbrillig sirbrillig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbloomf @matticbot @sirbrillig