Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wp-checkout component tests #36722

Closed
wants to merge 57 commits into from
Closed

Add wp-checkout component tests #36722

wants to merge 57 commits into from

Conversation

nbloomf
Copy link
Contributor

@nbloomf nbloomf commented Oct 14, 2019 •
edited by sirbrillig
Loading

Changes proposed in this Pull Request

Requires #36720

Looks like I messed something up when basing this branch.

  • Adds a test script using jest and enzyme, with some basic component tests. Try it out with npm install && npm test.

@sirbrillig
Checkout: Add README for new wp-checkout package
e4f007e 
This is just initial brainstorming.
@sirbrillig
Some updates
79275b1
@sirbrillig
Add list update callback idea
5fe767f
@sirbrillig
Switch onChangeItems to onDeleteItem
659c652
@sirbrillig
Hoist math requirement and onDeleteItem to parent
3866fbb
@sirbrillig
Remove defaultBillingContact
37b2e61
@sirbrillig
Implement updatePricesForAddress
6c97327
@sirbrillig
Prettier example
6dac580
@sirbrillig
Add missing useEffect import
2b6a075
@sirbrillig
Switch to use single total prop like Apple Pay
6c220f1
@sirbrillig
Calculate taxes whenever items change
0df983e
@sirbrillig
Add todo for styles
d3ffb36
@sirbrillig
Remove splitCheckoutLineItemsByType
97aca31
@sirbrillig
Add event to change plan length
0d0035b
@sirbrillig
Move main state to custom hook
962e96f
@sirbrillig
Run Prettier again
9a30995
@sirbrillig
Make UpSellCoupon a div
b591e71
@sirbrillig
Add Advanced API
d5c4832
@sirbrillig
Some adjustments from recent meeting
e0bac3f 
- Add web-payment method
- Mention stored payment methods
- Add checkoutHeader slot
- Add miscItems to OrderReview
- Allow deleting domain items
@sirbrillig
Add onEdit prop to CheckoutStep
1366106
@sirbrillig
Add Styles section
64b0c72
@sirbrillig
Add credits/coupons section
c97f120
@sirbrillig
Add some comments to MyCheckout and useShoppingCart
909988e
@sirbrillig
Correct spelling error
9a33a5d
@sirbrillig
Add Installation section
8d83039
@sirbrillig
Add hooks and submit functions to API ref
98690e7
@sirbrillig
Add args to submitCheckout
cb49354
@sirbrillig
Clean up prose and naming
6d814e5
@sirbrillig
Add icons to h2
2b3942e
@sirbrillig
Add types to Checkout props list
f687f7a
sirbrillig and others added 20 commits October 9, 2019 17:30
@nbloomf nbloomf requested a review from sirbrillig October 14, 2019 16:40
@nbloomf nbloomf requested a review from a team as a code owner October 14, 2019 16:40
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/wp-checkout-component-tests

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirbrillig
Copy link
Member

sirbrillig commented Oct 14, 2019 •
edited
Loading

Nice! Sorry I rebased the other branch out from under you. git fetch && git rebase -i origin/add/wp-checkout-component should fix it. Just delete all the commit lines except for the one you added.

@sirbrillig sirbrillig changed the title Add/wp checkout component tests Add wp-checkout component tests Oct 14, 2019
@nbloomf nbloomf closed this Oct 14, 2019
@nbloomf nbloomf mentioned this pull request Oct 14, 2019
Merged
@nbloomf
Copy link
Contributor Author

nbloomf commented Oct 14, 2019

Moved to #36744

@nbloomf nbloomf deleted the add/wp-checkout-component-tests branch October 14, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirbrillig sirbrillig Awaiting requested review from sirbrillig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbloomf @matticbot @sirbrillig