Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor overflow #28650

Closed
wants to merge 1 commit into from
Closed

Fix editor overflow #28650

wants to merge 1 commit into from

Conversation

pandah3
Copy link

@pandah3 pandah3 commented Nov 18, 2018

Changes proposed in this Pull Request

*Fixes editor overflow so that when media is added while user is creating a post, the page stays where the user inserted the media so they don't have to scroll back down to where they were.

Testing instructions

Starting at URL: https://wordpress.com/post

  • Add content to a new post. Make sure it's enough content so the first line scrolls off the top of the screen.

  • Click "add" button, click "media", select an image, and click "insert".

  • After image (or hyperlink) is inserted, page jumps back to the top of the page, rather than staying at the inserted media location.

  • Bug fixed; page stays at current user location after inserting media

@alisterscott alisterscott added OSS Citizen [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Post/Page Editor The editor for editing posts and pages. labels Nov 19, 2018
@pandah3
Copy link
Author

pandah3 commented Nov 21, 2018

cc @jameskoster Fixed this issue here: https://github.com/Automattic/wp- calypso/issues/16873#issuecomment-321504661

However, the proposed fix directly breaks PR #26577, which added the deleted block of code to prevent background scrolling when the modal is clicked.

I created a new PR that address both these issues here: PR #28737

@sarayourfriend sarayourfriend changed the base branch from master to trunk November 20, 2020 16:15
@github-actions
Copy link

github-actions bot commented May 5, 2021

This PR has been marked as stale due to lack of activity within the last 30 days.

@sixhours
Copy link
Contributor

Hi there! 👋 Looks like this was handled in #29832 so I'm going to close this out. But thanks very much for your contribution!

@sixhours sixhours closed this May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. OSS Citizen [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding media using the "add" button on the toolbar causes the editor to jump to the top of the page
3 participants