Prevent scrolling the background when a modal is open #26577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test:
Settings
and change the site language.What happened before:
What should happen:
This PR blocks background scrolling in all the modals in Calypso. I think that's the most sensible behaviour, since a modal dialog should prevent the user from interacting with the background entirely, and scrolling the background can be distracting. Can you folks think on any scenario when we would want the background to be scrollable?