-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site settings: allow site to be deleted if only purchases are non-refundable premium themes #27917
Conversation
Related PR dealing with the same scenario for account closure: #27411. |
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
df75cf8
to
9d6d222
Compare
Tested using these steps: Test 1
Saw an overlay prompting me to cancel my upgrades prior to deleting the site. After cancelling and refunding the theme I'm able to delete the site. Test 2
I was able to successfully confirm and finish deleting the site without having to remove the theme. Test 3
I was able to successfully delete the site. I'm also able to delete a site with no purchases as normal. Summary: From what I can see the PR is working as intended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and @KokkieH has very helpfully tested <3 🚀
Changes proposed in this Pull Request
Currently, it is not possible to delete a site with any active purchases. We direct the user to their Purchases to cancel everything first.
Premium themes are a special case, in that it is not possible to cancel them after they're outside the refund period. Users with a premium theme therefore are unable to delete their site.
This PR allows users to delete a site if the only purchases attached to it are non-refundable premium themes.
Testing instructions
Visit http://calypso.localhost:3000/settings/general and test with sites that:
Only have premium themes that are not refundable. Verify that you can now proceed with site deletion.
Do not have any premium themes or purchases. You should still be able to proceed with site deletion.
Have purchases besides premium themes. Verify that you are shown the warning popover, and that it is not possible to delete the site.
Fixes #17012.