Gutenberg: oembed api middleware #27437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwwar
added
[Status] In Progress
[Goal] Gutenberg
|
Test live: https://calypso.live/?branch=update/oembed |
|
Also added #27438 |
|
closing in favor of #27486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27296
@kwight here's something to get you started with. I added a messy middleware example that translates oembed requests to the v1.1 format (only tested with youtube vids atm). There's still remaining work to transform the response into what the block expects, since the placeholder is blank. Feel free to completely take over this PR or open a fresh branch/PR.
Something I noticed while sketching this out is that we'll run into trouble by calling
wpcomProxyRequestdirectly. Clients that use oauth, like desktop won't work here. We can follow up on this in another PR