Framework: update to react 16 (take three) #19723

samouri · 2017-11-13T23:40:19Z

Everyone knows the third time is the charm.

to do:

interpolate components: Bump to allow for React 16, fix test interpolate-components#12, Framework: Bump i18n-calypso to 1.8.4 #19658
fix ssr: enable user-bootstrapping when secrets are present #20267

To Test and Verify

local dev
docker. note: ssr will be broken unless secrets.json is configured.
there should be no reference to React < 16 within our shrinkwrap

matticbot · 2017-11-13T23:40:20Z

Test live: https://calypso.live/?branch=framework/react16-take3

kwight · 2017-11-17T21:57:04Z

Note that notifications-panel (the react16 branch aligned with this update) is now at 2.1.1.

sirreal · 2017-11-27T13:42:57Z

Note that notifications-panel (the react16 branch aligned with this update) is now at 2.1.1.

@kwight 2.1.1 does not seem to be published yet 😬

sirreal · 2017-11-27T15:18:00Z

This had become quite out of date.

Rebased, [email protected], update-deps, force push.

sirreal · 2017-11-27T15:54:51Z

Rebased again, sorry. [email protected] was causing errors. Back to 2.0.0

kwight · 2017-11-27T18:33:23Z

Ack, will verify 2.1.1.

kwight · 2017-11-27T19:34:11Z

[email protected] published 👍

samouri · 2017-11-28T20:53:11Z

I'm basing this off the ssr fix now

samouri · 2017-11-29T00:18:49Z

🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 
⭐️ ⭐️ ⭐️ ⭐️ ⭐️ ⭐️ ⭐️ ⭐️ ready for testing  ⭐️ ⭐️ ⭐️ ⭐️ ⭐️ ⭐️ ⭐️ ⭐️ 
🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑 🐑

sirreal

I've done the following smoke testing and encountered no issues 🎉

local dev
docker. note: ssr will be broken unless secrets.json is configured.
there should be no reference to React < 16 within our shrinkwrap

For SSR I see /themes is correct (logged in and logged out) if config/secrets.json is included. Otherwise I see the following message and the issue pictured here.

Disabling server-side user-bootstrapping because of a missing secrets.json

sirreal · 2017-11-29T07:31:40Z

package.json

@@ -106,7 +106,7 @@
    "ms": "0.7.1",
    "name-all-modules-plugin": "1.0.1",
    "node-sass": "4.5.3",
-    "notifications-panel": "1.2.7",
+    "notifications-panel": "2.0.0",


Should we get the current 2.1.1?

also React 16.2!

Love those <>Fragments</> 🎉

sirreal · 2017-11-29T09:10:16Z

Running tests now produces far fewer warnings, which is nice. Now we have a new annoyance:

console.error node_modules/fbjs/lib/warning.js:33
Warning: React depends on requestAnimationFrame. Make sure that you load a polyfill in older browsers. http://fb.me/react-polyfills

Relevant conversation seems to be happening here: jestjs/jest#4545. Just a warning, so nothing blocking and we can ship a fix later.

ockham · 2017-11-29T16:27:02Z

package.json

@@ -277,7 +277,7 @@
    "prettier": "github:automattic/calypso-prettier#717e62ee",
    "pretty-bytes": "4.0.2",
    "react-codemod": "reactjs/react-codemod",
-    "react-test-renderer": "15.6.2",
+    "react-test-renderer": "16.0.0",


Also bump to 16.2.0?

samouri · 2017-11-29T16:48:01Z

I've had to bump back down to 2.0 due to issues withesnext

ockham · 2017-11-29T16:58:26Z

I've had to bump back down to 2.0 due to issues withesnext

My bad. Context: #19698

To fix, we can:

either merge Framework: Transpile untranspiled node_modules, Take Two #19698
or change back esnext to module in https://github.com/Automattic/notifications-panel
or add a build step, publish that to npm, and set main to point to the dir that holds the transpiled code

samouri · 2017-11-29T17:00:37Z

To fix, we can:

Am I right in thinking that can all happen after this PR lands?

This reverts commit 577331f.

samouri · 2017-11-29T17:10:48Z

after upgrading a few packages (and then redowngrading notif-panel), i'll do another smoke test and then ask for an E2E from flow-patrol

ockham · 2017-11-29T17:11:01Z

Am I right in thinking that can all happen after this PR?

Oh, absolutely! Sry for not having been clear 😄

ockham · 2017-11-29T17:11:59Z

Am I right in thinking that can all happen after this PR?

Oh, absolutely! Sry for not having been clear 😄

As pretty much anything that doesn't make Calypso go up in 🔥s at this point 😄

bsessions85 · 2017-11-29T20:54:33Z

E2E tests passed

samouri added Build Framework [Status] In Progress [Type] Enhancement labels Nov 13, 2017

samouri self-assigned this Nov 13, 2017

sirreal force-pushed the framework/react16-take3 branch from fe665b1 to beed2bb Compare November 27, 2017 15:17

sirreal force-pushed the framework/react16-take3 branch from beed2bb to 51e8ccb Compare November 27, 2017 15:54

sirreal force-pushed the framework/react16-take3 branch from 51e8ccb to d093ff6 Compare November 27, 2017 15:55

bluefuton mentioned this pull request Nov 27, 2017

Framework: add error boundaries to Devdocs #20252

Merged

samouri mentioned this pull request Nov 27, 2017

enable user-bootstrapping when secrets are present #20267

Merged

samouri force-pushed the framework/react16-take3 branch from d093ff6 to 66e321e Compare November 28, 2017 20:54

samouri changed the base branch from master to config/re-enable-bootstrap November 28, 2017 20:54

samouri added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Nov 28, 2017

sirreal approved these changes Nov 29, 2017

View reviewed changes

samouri changed the base branch from config/re-enable-bootstrap to master November 29, 2017 16:17

samouri force-pushed the framework/react16-take3 branch 2 times, most recently from 0bae1d6 to 0349330 Compare November 29, 2017 16:18

samouri removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 29, 2017

samouri added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 29, 2017

ockham reviewed Nov 29, 2017

View reviewed changes

samouri added [Status] In Progress and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 29, 2017

samouri added 4 commits November 29, 2017 09:09

Revert "Revert "Framework: update to React 16, try 2" (#19609)"

9d34288

This reverts commit 577331f.

shrinkwrap

c22ad85

update the dependencies

ea89640

downgrade notif-panel and shrinkwrap

fc1dbc3

samouri force-pushed the framework/react16-take3 branch from fd8be57 to fc1dbc3 Compare November 29, 2017 17:09

ockham mentioned this pull request Nov 29, 2017

package.json: Change main to esnext Automattic/notifications-panel#174

Merged

samouri added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Nov 29, 2017

samouri merged commit b1c4fef into master Nov 29, 2017

matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 29, 2017

sirreal deleted the framework/react16-take3 branch December 13, 2017 11:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Framework: update to react 16 (take three) #19723

Framework: update to react 16 (take three) #19723

samouri commented Nov 13, 2017 •

edited

Loading

matticbot commented Nov 13, 2017

kwight commented Nov 17, 2017

sirreal commented Nov 27, 2017

sirreal commented Nov 27, 2017

sirreal commented Nov 27, 2017 •

edited

Loading

kwight commented Nov 27, 2017

kwight commented Nov 27, 2017

samouri commented Nov 28, 2017

samouri commented Nov 29, 2017 •

edited

Loading

sirreal left a comment

sirreal Nov 29, 2017

samouri Nov 29, 2017

sirreal Nov 29, 2017

sirreal commented Nov 29, 2017

ockham Nov 29, 2017

samouri commented Nov 29, 2017

ockham commented Nov 29, 2017

samouri commented Nov 29, 2017 •

edited

Loading

samouri commented Nov 29, 2017 •

edited

Loading

ockham commented Nov 29, 2017

ockham commented Nov 29, 2017

bsessions85 commented Nov 29, 2017

Framework: update to react 16 (take three) #19723

Framework: update to react 16 (take three) #19723

Conversation

samouri commented Nov 13, 2017 • edited Loading

To Test and Verify

matticbot commented Nov 13, 2017

kwight commented Nov 17, 2017

sirreal commented Nov 27, 2017

sirreal commented Nov 27, 2017

sirreal commented Nov 27, 2017 • edited Loading

kwight commented Nov 27, 2017

kwight commented Nov 27, 2017

samouri commented Nov 28, 2017

samouri commented Nov 29, 2017 • edited Loading

sirreal left a comment

Choose a reason for hiding this comment

sirreal Nov 29, 2017

Choose a reason for hiding this comment

samouri Nov 29, 2017

Choose a reason for hiding this comment

sirreal Nov 29, 2017

Choose a reason for hiding this comment

sirreal commented Nov 29, 2017

ockham Nov 29, 2017

Choose a reason for hiding this comment

samouri commented Nov 29, 2017

ockham commented Nov 29, 2017

samouri commented Nov 29, 2017 • edited Loading

samouri commented Nov 29, 2017 • edited Loading

ockham commented Nov 29, 2017

ockham commented Nov 29, 2017

bsessions85 commented Nov 29, 2017

samouri commented Nov 13, 2017 •

edited

Loading

sirreal commented Nov 27, 2017 •

edited

Loading

samouri commented Nov 29, 2017 •

edited

Loading

samouri commented Nov 29, 2017 •

edited

Loading

samouri commented Nov 29, 2017 •

edited

Loading