-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
package.json
Outdated
@@ -2,7 +2,7 @@ | |||
"name": "notifications-panel", | |||
"version": "1.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is probably worth a major version bump, no? since software already using this would have to update in order not to break?
To better denote we're dealing with untranspiled code. See http://2ality.com/2017/06/pkg-esnext.html
We previously used `main` inside of `package.json` to define where to pull in untranspiled code into the project and this change starts using the `esnext` property as seen in http://2ality.com/2017/06/pkg-esnext.html That means (to me at least) that any software which has been using this will have to make changes in order to not break when updating from the previous versions when their build systems looked for the `main` property.
1bdb93a
to
48348a9
Compare
@gwwar @kwight I have updated this with a major version bump (see the commit description). Could you two consider this change and indicate if you have any hesitation or questions? This is a change to help @ockham improve Calypso's build process by automatically inferring which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending review from others
@ockham do you have a strict timeline for this? We've moved to scheduled releases for |
To add to that Calypso gets the beta release so unless it's really urgent, it'd be slated for Nov 8. |
No strict/urgent timeline, but would totally appreciate this being merged! |
Thanks @ockham we'll try to test/merge this soon, though for now we'll stick with the Nov 8 version bump. |
THis PR has been replicated on the `react16` branch as v2.1.0. This minor version bump will allow either of the two Calypso-related PRs to land first. Related: * Automattic/wp-calypso#16870 * Automattic/wp-calypso#19083
I've committed these changes both to |
D'oh, this won't work until we merge Automattic/wp-calypso#19698 Quoting Automattic/wp-calypso#19723 (comment):
|
centered images into Automattic/wp-calypso.
…and centred images into Automattic/wp-calypso. (#199)
To better denote we're dealing with untranspiled code.
Companion Calypso PR: Automattic/wp-calypso#16870
To provide a bit of an explanation --
esnext
is a custom field.main
) as a flag to indicate that this is a package's entrypoint for untranspiled code here.This is a strategy found at http://2ality.com/2017/06/pkg-esnext.html.
Suggested order:
notifications-panel
version bump with Framework: Transpile untranspiled node_modules wp-calypso#16870