Site Settings: Adds holidaysnow to general site settings #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebinnion
added
[Feature] Site Settings
|
QA 👍 — works exactly as expected. Nice! |
| <span>{ this.translate( 'I would like my site to be private, visible only to users I choose' ) }</span> | ||
| </label>; | ||
| } | ||
| var site = this.props.site; |
|
|
lezama
added
[Status] Ready to Merge
and removed
[Status] Needs Review
ebinnion
added a commit
that referenced
this pull request
Dec 2, 2015
Site Settings: Adds holidaysnow to general site settings
|
I can no longer see the option to disable snow for a simple site in Calypso - it still exists in wp-admin for simple sites. Raised here: #20395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1123
@jeherve reported in #1123 that the holiday snow options weren't ported to Calypso. In #1138, I added the holiday snow override to
/meand this PR adds the holiday snow site setting to the/settings/general/$site.Note: The first two commits are ESLint fixes. So, if you'd like to see the changeset to add
holidaysnow, see the third commit.To test:
add/site-settings-holiday-snowbranch/me/accountand ensure you have holiday snow enabled/settings/general/$sitewhere$siteis a WP.com site and ensure that snow is enabled$site. Do you see snow? Good/settings/general/$siteand disable snow.$site. You should not see snow./settings/general/$sitewhere$siteis a Jetpack site. You should not see the holiday snow option yet. Since this requires an API change, it is unlikely that holiday snow will be changeable via the API until 4.0 (late January 2016)cc @lancewillett who pointed the issue out to me and @lezama who has done some work in
form-general.WP.com site
Jetpack site
