Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Holiday Snow settings: add site and user option #1123

Closed
jeherve opened this issue Dec 1, 2015 · 2 comments · Fixed by #1210
Closed

Holiday Snow settings: add site and user option #1123

jeherve opened this issue Dec 1, 2015 · 2 comments · Fixed by #1210
Assignees
@ebinnion
Labels
[Feature] Site Settings All other general site settings. [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. [Pri] High Address as soon as possible after BLOCKER issues [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@jeherve
Copy link
Member

jeherve commented Dec 1, 2015

It's December 1st! Snow is back on WordPress.com and Jetpack sites, and will fall until January 4th.

There are 2 settings related to that feature:

  1. A site setting, available under Settings > General in wp-admin. I didn't find that option in the API when looking at the sites/%ID endpoint.
  2. A user setting, that used to be available in the account settings, but that wasn't ported to Calypso. It allows WordPress.com users to disable snow for all WordPress.com blogs, when they're logged in. The option is available in the API, via the /me/settings/ endpoint (option name is holidaysun).

It would be nice if both options were made available in Calypso.
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Site Settings All other general site settings. [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. labels Dec 1, 2015
@lancewillett lancewillett added the [Pri] High Address as soon as possible after BLOCKER issues label Dec 1, 2015
@ebinnion ebinnion mentioned this issue Dec 1, 2015
Merged
@lancewillett
Copy link
Contributor

User setting added in PR: #1138

Site setting is pending a PR

@Viper007Bond Viper007Bond reopened this Dec 1, 2015
@Viper007Bond
Copy link
Contributor

Oops.

@ebinnion ebinnion self-assigned this Dec 2, 2015
@ebinnion ebinnion mentioned this issue Dec 2, 2015
Merged
@ajesse11x ajesse11x mentioned this issue Nov 4, 2022
Open
@awaisab172 awaisab172 mentioned this issue Nov 5, 2022
Open
@ajesse11x ajesse11x mentioned this issue Dec 25, 2022
Open
@awaisab172 awaisab172 mentioned this issue Dec 26, 2022
Open
@mdno mdno mentioned this issue Jan 9, 2023
Open
@anarh anarh mentioned this issue Jan 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebinnion ebinnion

Labels
[Feature] Site Settings All other general site settings. [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. [Pri] High Address as soon as possible after BLOCKER issues [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Site Settings: Adds holidaysnow to general site settings Automattic/wp-calypso
4 participants
@lancewillett @Viper007Bond @jeherve @ebinnion