Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo won't save while Gutenberg plugin is activated #54055

Closed
ccwalburn opened this issue Jun 27, 2021 · 62 comments
Closed

Logo won't save while Gutenberg plugin is activated #54055

ccwalburn opened this issue Jun 27, 2021 · 62 comments
Labels
[Feature] Customizer The site customizer for traditional, non-block themes. Logo [Pri] High Address as soon as possible after BLOCKER issues Triaged To be used when issues have been triaged. [Type] Bug User Waiting This issue has many user reports. Following here https://github.com/Automattic/wp-calypso/projects/1

Comments

@ccwalburn
Copy link

ccwalburn commented Jun 27, 2021

Updating the logo in the Site identity section of the Customizer won't save. It allows you to change it, and clicking Save Changes appears to work, but when you go to the site, or back to the Customizer afterward, the old logo is back. This does not happen if the Gutenberg plugin is deactivated.

Steps to reproduce the behavior

  1. Ensure Gutenberg plugin is activated.
  2. Go to Site Identity in Customizer
  3. Click Change Logo and select a new logo
  4. Click Save Changes and close the Customizer
  5. Go to front end of site or back to the Customizer

What I expected to happen

I expected to see the new logo.

What actually happened

I saw the old logo

(Some users report the logo disappears, instead.)

Context

This was a user report. I haven't tested on my own site.
4095490-zen

Is this specific to the applied theme? Which one?

This is for the Hever theme. It can happen with any theme using a custom logo.

Does this happen on simple or atomic sites or both?

This was an AT site. (But happens on Simple Sites as well.)

Is there any console output or error text?

No

Level of impact (Does it block purchases? Does it affect more than just one site?)

Reproducibility (Consistent, Intermittent) Leave empty for consistent.

Screenshot / Video: If applicable, add screenshots to help explain your problem.

Possible workarounds

  • Select a different image and save that as the logo in the Customizer. Then go back to the Customizer again and save the image you actually want as your logo.
  • Open a post/page in the editor and insert a Site Logo block. Replace the image with the desired logo and save the post. (You can delete the block from the post, or the whole post after you save it once.)
  • Deactivate Gutenberg plugin (for Atomic sites)
@ccwalburn
Copy link
Author

ccwalburn commented Jun 27, 2021

Another case here: 30355259-hc
This site used the Baskerville 2 theme.

@donalirl
Copy link

Another case #30339833-hc with a third-party theme.

@yashitamittal11
Copy link
Contributor

Also reported here- #54017

@jackiejade
Copy link

Another case here with Veni theme and Gutenberg deactivated fixes the issue: #30369699-hc

@kwight kwight added Atomic [Feature] Customizer The site customizer for traditional, non-block themes. Logo labels Jun 28, 2021
@KirkwallDay
Copy link

Another case here: 13266578-hc: Hever theme, deactivating Gutinberg worked. Tried to re-activate it after to see if they could still take advantage of the features. Reactivating the plugin removed the logo again. Advised them to leave it off.

@creativecoder
Copy link
Contributor

This appears to happen when the site_logo option and custom_logo theme mod get out of sync. Recent versions of Gutenberg have code to keep these in sync, but it only runs at specific times.

Example

  • site_logo option is set to image 1
  • custom_logo theme mod is set to image 2
  • You'll see the image 1 in the customizer, because the site_logo (setting for the Site Logo block) overrides the custom_logo setting.
  • But if you want your logo to be image 2, and you try to save that image in the customizer (to update the custom_logo setting), it won't update, because custom_logo is already set to image 2.
  • This prevents the Gutenberg code running to update the site_logo, and so you're logo stays the same.

Two possible workarounds, until this is fixed:

  1. Select a different image and save that as the logo in the Customizer. Then go back to the Customizer again and save the image you actually want as your logo.
  2. Open a post/page in the editor and insert a Site Logo block. Replace the image with the desired logo and save the post. (You can delete the block from the post, or the whole post after you save it once.)

@creativecoder
Copy link
Contributor

^ Note that you'll need the Gutenberg plugin activated for these workarounds to take effect.

@carladoria
Copy link

another case with a Simple site in 30373872-hc
xivfurniture.com
Is there any workaround for Simple sites? Tried adding/removing/saving several images

@aisajib
Copy link

aisajib commented Jun 29, 2021

Also reported in 30360146-hc - the second workaround worked (the first one didn't work since when I went back to the customizer, there were no images to begin with, and selecting another didn't do anything).

@galakhyati
Copy link

Another case here:
Simple site.
Site: https://traductionsbrio.com/

@lizswafford
Copy link

29967113-hc
Simple Site.
Workaround using Site Logo Block fixed it.

@sophiegyo
Copy link

Atomic site, same issue: #30385906-hc

Logo just didn't display at all (in the Customizer, or anywhere else) with Gutenberg active.

Fixed by: deactivating Gutenberg (version 10.9.1)

@druesome
Copy link
Contributor

Chat: #30387014-hc

Gave them this CSS as a workaround. Note that there has to be a site title and it must be visible on the site for this to work.

.selector a {
height: 80px;       
width:  400px;
white-space: nowrap;
overflow: hidden;
text-indent: -9999px;   
margin: 0 !important;
background: url(URLTOIMAGE) no-repeat;
background-size: contain;
display: inline-block;
}

@KirkwallDay
Copy link

Another instance here: 5134826-hc.
The workarounds didn't work. They will need to be notified when the bug is fixed.

@KirkwallDay
Copy link

Another instance here: 27261916-hc
Workaround 2 worked.

I think the workarounds only work if the site currently has a logo, with no logo before the bug occurred, they seem not to work.

@dhackneya8c
Copy link

Another report: 30388973-hc
Deactivating Gutenberg worked

@AtrumGeost
Copy link
Contributor

Another case: 29224901-hc
Deactivating the Gutenberg plugin worked

@AtrumGeost
Copy link
Contributor

Got another report on a simple site: 4105602-zd-woothemes

The workaround mentioned above worked:

Open a post/page in the editor and insert a Site Logo block. Replace the image with the desired logo and save the post. (You can delete the block from the post, or the whole post after you save it once.)

@xpurichan
Copy link

Experienced this in 30405625-hc. Deactivated Gutenberg, changed the logo, reactivated Gutenberg.

@KirkwallDay
Copy link

Another instance here: 29989649-hc
Using the site-logo block work-around worked, the site had a logo before the bug occurred.

@Thelmachido
Copy link

Another case here: 4103714-ZD
The below workaround worked
Open a post/page in the editor and insert a Site Logo block. Replace the image with the desired logo and save the post. (You can delete the block from the post, or the whole post after you save it once.)

@kriskarkoski
Copy link
Contributor

4103158-zen

@JoshuaGoode
Copy link

JoshuaGoode commented Jul 3, 2021

I encountered this on 28753841-hc

Not sure if it will stick but to resolve we were able to temporarily deactivate Gutenberg, set the logo in the Customizer, and then reactivate Gutenberg.

So:

  1. Deactivate Gutenberg
  2. Set the logo in the customizer and Save Changes.
  3. Reactivate Gutenberg

We flushed cache and tried adjusting things in the Customizer again. The logo remained.

@joweber123
Copy link

Simple site - 4113750-zen

Workaround using site logo block resolved issue.

@poojashetty18
Copy link

poojashetty18 commented Jul 4, 2021

Another case: 30098382-hc
Deactivating the Gutenberg plugin worked. Reactivating it back after updating the logo was still showing the wrong logo.

@KirkwallDay
Copy link

Another instance here - 4112055-zen
Workaround 2 using a site-logo block worked here.

@kaitohm
Copy link

kaitohm commented Jul 5, 2021

Another instance: 4115546-zd-woothemes
Asked them to try workaround 2 - replacing logo in Site Logo Block

@happychait
Copy link

#1627073-hc

Applied the Site Logo block workaround here.

@kaitohm
Copy link

kaitohm commented Jul 5, 2021

Another instance: 4115259-zd-woothemes
Asked them to try workaround 2 - replacing logo in Site Logo Block

@fresatomica
Copy link

fresatomica commented Jul 5, 2021

Another report: https://wordpress.com/forums/topic/my-logo-is-disappearing/
The workaround didn't work.

@synora
Copy link
Contributor

synora commented Jul 5, 2021

4117160-zd. Deactivating Gutenberg, saving the site logo in the Customizer, then reactivating Gutenberg again worked.

@ccwalburn
Copy link
Author

30482549-hc
User's logo disappeared.
Adding the Site Logo block to a page fixed it.

@liviopv
Copy link

liviopv commented Jul 5, 2021

Another 4117643-hc. Changing the Site Logo block worked.

@Nic-Sevic
Copy link
Contributor

another instance here: 30016318-hc
workaround provided with CSS

@joweber123
Copy link

Simple site -4117408-zen

Workaround using site logo block resolved issue.

@gwensmithx
Copy link

AT site - 4118278-zen
Deactivating the gutenberg plugin worked.

@zdenys
Copy link
Contributor

zdenys commented Jul 6, 2021

Simple Site 4118132-zd-woothemes Asked them to try the two workarounds from above.

@sguzovskaia
Copy link

sguzovskaia commented Jul 6, 2021

Somewhat a similar issue: the site logo is getting re-added again after the user removes it and saves changes in Customizer.
Reproduced the issue from my end. Two workarounds from above didn't work. AT site
The user resolved it by permanently removing the logo image from the media library and it helped to remove the logo.
30496468-hc

@jartes
Copy link
Contributor

jartes commented Jul 6, 2021

Another one on 30174430-hc with the Ippo theme.

Fixed by adding the Site logo block, setting the logo and then removing it.

@creativecoder
Copy link
Contributor

D63662-code has been deployed to hotfix this issue for Simple Sites. I'm trying to get the proper fix into Gutenberg 11.0.0.

@creativecoder
Copy link
Contributor

A hotfix for Atomic sites will go out shortly, as well, which should resolve this issue for all WP.com users.

But please reopen if there are additional reports.

@poojashetty18
Copy link

Another report on 30961676-hc
Simple site using Luxury theme.
Fixed by adding the Site logo block, setting the logo and then removing it.

@poojashetty18 poojashetty18 reopened this Aug 4, 2021
@synora
Copy link
Contributor

synora commented Aug 4, 2021

I'm unable to replicate this on simple or Atomic sites.

@synora synora closed this as completed Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Customizer The site customizer for traditional, non-block themes. Logo [Pri] High Address as soon as possible after BLOCKER issues Triaged To be used when issues have been triaged. [Type] Bug User Waiting This issue has many user reports. Following here https://github.com/Automattic/wp-calypso/projects/1
Projects
None yet
Development

No branches or pull requests