Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Me: 2fa: add title to print page for 2fa backup codes #398

Closed
v18 opened this issue Nov 21, 2015 · 6 comments · Fixed by #39166
Closed

Me: 2fa: add title to print page for 2fa backup codes #398

v18 opened this issue Nov 21, 2015 · 6 comments · Fixed by #39166
Labels
[Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. Good First Issue Small, contained issues. Security [Type] Enhancement

Comments

@v18
Copy link
Contributor

v18 commented Nov 21, 2015

When printing backup codes in Chrome the default title for the document is "Untitled". Which is no big deal if you're printing directly, but I was saving mine temporarily to print them all in a batch and then delete. It would be a simple change to have it be something generic like "WordPress.com - Backup Codes for usernamehere"

Steps to reproduce:

  1. Go to /me/security
  2. Generate new backup codes
  3. Print them
  4. See how the page doesn't have a title?

screen shot 2015-07-14 at 23 07 42

a9a21b6e-2a7d-11e5-971c-d241d423f79a

This is related to #385
@v18 v18 added [Type] Enhancement [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. Security labels Nov 21, 2015
@v18 v18 mentioned this issue Nov 21, 2015
Closed
@lancewillett lancewillett added the Good First Issue Small, contained issues. label Dec 4, 2015
@noxee
Copy link
Contributor

noxee commented Apr 8, 2016

Is this still need?

In client/me/security-2fa-backup-codes-list/index.jsx there is now a title being set as shown in the code below:

let html = '<html><head><title>';

html += this.translate( 'Backup verification codes' );
html += '</title></head>';

@v18
Copy link
Contributor Author

v18 commented Apr 13, 2016

@noxee - were you able to see a title when printing the 2FA codes from the site?

@noxee
Copy link
Contributor

noxee commented Apr 13, 2016

@v18 I can see title Backup verification codes as shown in the screenshot below.

screen shot 2016-04-13 at 9 53 34 am

@blowery
Copy link
Contributor

blowery commented Sep 19, 2016

Closing this as good enough. I don't think we want our domain name on the set of code.

@blowery blowery closed this as completed Sep 19, 2016
@josephscott
Copy link
Contributor

@blowery I'm going to disagree. I recently ran into this exact issue. I've got a significant stack of paper printouts of 2fa backup codes for various services that I use. If I hadn't noticed the lack of detail WordPress.com provided and wrote down the details with pen, these backup codes would be essentially useless.

The nearly blank list that WordPress.com provides is a problem waiting to happen, at the worst possible moment.

At a minimum the site name ( WordPress.com ) should be included in the print out. Second, and really for me just as important, the username associated with the account should be shown as well.

For that second item, we already do that for the file name when saving. The printout should get the same benefit. For people managing multiple WordPress.com accounts this is a big deal.

The username should already be available to getBackupCodeHTML() via this.props, so I don't expect that would be hard to add. The site name might be a bit more involved, if we want it for use outside of WordPress.com ( is the site name a config level option some where? ).

/cc @sgomes

@josephscott josephscott reopened this Jan 29, 2020
@blowery
Copy link
Contributor

blowery commented Jan 30, 2020

@josephscott I think I actually disagree with 2016 me too.

blowery added a commit that referenced this issue Jan 30, 2020
@blowery
Add site name and username to backup code printout
25665a9 
Fixes #398
@blowery blowery mentioned this issue Jan 30, 2020
Merged
blowery added a commit that referenced this issue Jan 31, 2020
@blowery
Add site name and username to backup code printout
7bf1bf6 
Fixes #398
blowery added a commit that referenced this issue Jan 31, 2020
@blowery
Me:2FA: Add site name and username to backup code printout (#39166)
f7094e2 
Fixes #398
This was referenced Apr 7, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. Good First Issue Small, contained issues. Security [Type] Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Me:2FA: Add site name and username to backup code printout Automattic/wp-calypso
5 participants
@blowery @lancewillett @josephscott @noxee @v18