Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg: Revert temporary fix for linking issue in Safari #33004

Closed
mmtr opened this issue May 14, 2019 · 3 comments
Closed

Gutenberg: Revert temporary fix for linking issue in Safari #33004

mmtr opened this issue May 14, 2019 · 3 comments
Assignees
@gwwar
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg

Comments

@mmtr
Copy link
Member

mmtr commented May 14, 2019

In order to avoid issues like #32965, we implemented D28094-code as temporary fix while we wait for changes from WordPress/gutenberg#15576 to arrive to WP.com.

This issue is a reminder to revert D28094-code during the next Gutenberg update, although we might want to wait until all unsafe getRangeAt usages are fixed (WordPress/gutenberg#15606).
@mmtr mmtr added the [Goal] Gutenberg Working towards full integration with Gutenberg label May 14, 2019
@mmtr mmtr mentioned this issue May 14, 2019
Closed
@mmtr
Copy link
Member Author

mmtr commented May 20, 2019 •
edited
Loading

@gwwar I forgot to bring up this one during our meeting today.

Do you think we should revert this one now that WordPress/gutenberg#15576 is in WP.com, or should we wait for WordPress/gutenberg#15606?

I always prefer to be on the safer side but I don't know if overriding a native function can be considered safer than not avoiding a potential issue with the autocomplete component which never has been reported.

@gwwar
Copy link
Contributor

gwwar commented May 21, 2019

We can wait for WordPress/gutenberg#15606, if I find some time I'll try spinning up a patch for that if no one else takes it

@gwwar gwwar self-assigned this Sep 15, 2019
@gwwar
Copy link
Contributor

gwwar commented Sep 15, 2019 •
edited
Loading

Landed D32837-code

@gwwar gwwar closed this as completed Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gwwar gwwar

Labels
[Goal] Gutenberg Working towards full integration with Gutenberg
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmtr @gwwar