Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Avoid unguarded getRangeAt (Autocomplete) #15606

Closed
2 tasks
aduth opened this issue May 13, 2019 · 0 comments · Fixed by #16212
Closed
2 tasks

Components: Avoid unguarded getRangeAt (Autocomplete) #15606

aduth opened this issue May 13, 2019 · 0 comments · Fixed by #16212
Labels
Browser Issues Issues or PRs that are related to browser specific problems Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@aduth
Copy link
Member

aduth commented May 13, 2019

Previously: #11457, #15576, #11209

Safari will throw errors when attempting to call Selection#getRangeAt when there are no ranges in the selection. This has resulted in block errors on multiple occasions in the past (#11209, #15576).

Tasks:

@aduth aduth added [Type] Task Issues or PRs that have been broken down into an individual action to take Good First Issue An issue that's suitable for someone looking to contribute for the first time Browser Issues Issues or PRs that are related to browser specific problems [Package] Components /packages/components labels May 13, 2019
@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants