Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: Adding link on Paragraph block breaks the block on Safari #32965

Closed
carinapilar opened this issue May 10, 2019 · 5 comments
Closed
Assignees
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug

Comments

@carinapilar
Copy link

Steps to reproduce

  1. Open your WordPress.com account on Safari.
  2. Go to Site > Pages.
  3. Create a new page.
  4. Add a text using a Paragraph block.
  5. Select part of the text and hyperlink it.

I was able to replicate the above on an AT and Simple site.

What I expected

The link to work.

What happened instead

It breaks the block.

Browser / OS version

Safari Version 12.1 (13607.1.40.1.5)
OS X 10.13.6

Screenshot / Video

GutenIssue

This is what it shows in the Console:

Screen Shot 2019-05-10 at 17 27 38

Context / Source

#user-report
2017169-zen

@carinapilar carinapilar added [Type] Bug [Goal] Gutenberg Working towards full integration with Gutenberg labels May 10, 2019
@gwwar gwwar added the [Pri] High Address as soon as possible after BLOCKER issues label May 10, 2019
@gwwar
Copy link
Contributor

gwwar commented May 10, 2019

Verified on Simple/Atomic but not in Gutenberg nightly.

It's more specifically breaking on window.getSelection().getRangeAt(0)
Screen Shot 2019-05-10 at 1 49 09 PM

Which I think lines up with https://github.com/WordPress/gutenberg/blob/4108e37d3771b5871cd720216432b5bbd5255551/packages/format-library/src/link/inline.js#L82

@gwwar
Copy link
Contributor

gwwar commented May 10, 2019

Update: I can reproduce this in Gutenberg master with the following steps:

In Safari:

  • Add a link to a paragraph
  • Click on another paragraph
  • Click directly on the link you added

May-10-2019 14-49-33

@mmtr
Copy link
Member

mmtr commented May 11, 2019

D28094-code has a temporary fix for WP.com sites while we wait for changes from WordPress/gutenberg#15576

@mmtr mmtr self-assigned this May 11, 2019
@mmtr
Copy link
Member

mmtr commented May 14, 2019

Fixed by D28094-code.

@mmtr
Copy link
Member

mmtr commented May 14, 2019

Created #33004 as a reminder to revert D28094-code during the next Gutenberg update in WP.com sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug
Projects
None yet
Development

No branches or pull requests

3 participants