Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server Side Rendering: Set title via React #181

Closed
hoverduck opened this issue Nov 19, 2015 · 1 comment
Closed

Server Side Rendering: Set title via React #181

hoverduck opened this issue Nov 19, 2015 · 1 comment
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] BLOCKER Requires immediate attention. Server Side Rendering [Type] Task
Milestone
Themes: Improvements

Comments

@hoverduck
Copy link
Contributor

We're currently setting document.title in client/lib/screen-title. This won't work for server-side rendering, though.

Let's use React to set the title, or to be more precise, https://github.com/gaearon/react-document-title or https://github.com/nfl/react-helmet (the latter is also suitable for meta tags, which will be relevant for SEO).

This will probably require #179 first.
@folletto folletto added [Pri] High Address as soon as possible after BLOCKER issues [Pri] BLOCKER Requires immediate attention. and removed [Pri] High Address as soon as possible after BLOCKER issues labels Nov 25, 2015
@ehg ehg modified the milestones: Themes: Future, Themes: Showcase M3-LoggedOut Dec 16, 2015
@ockham ockham mentioned this issue Jan 15, 2016
Merged
@ehg
Copy link
Member

ehg commented Feb 8, 2016

Closing due to #2182

@ehg ehg closed this as completed Feb 8, 2016
jsnajdr pushed a commit that referenced this issue Jan 27, 2020
@retrofox @jsnajdr
Merge pull request #181 from Automattic/update/webapp-testing-page
8d88fa0 
webapp: testting -> update mocha js file
This was referenced Nov 11, 2021
Open
Open
@anarh anarh mentioned this issue Oct 26, 2022
Open
@mdno mdno mentioned this issue Oct 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] BLOCKER Requires immediate attention. Server Side Rendering [Type] Task
Projects
None yet
Milestone
Themes: Improvements
Development

No branches or pull requests
3 participants
@folletto @ehg @hoverduck