-
Notifications
You must be signed in to change notification settings - Fork 362
Blockbase: Use the Global Styles rest API in the customizer #5492
Conversation
It's bit tricky to review this with the coding standards changes combined. Would you be able to split that into two different commit, or two different PRs? Thansk! |
This reverts commit f1a3133.
07819ca
to
5361868
Compare
This reverts commit f1a3133.
f45b10f
to
774f156
Compare
This looks great. Just a few suggestion and I think we can merge |
This seems to blow away font customizations. I believe that portion will need another look. Steps (with Blockbase): Using the Customizer:
I tested the same steps against /trunk to verify that the behavior was expected before this change. |
The last problem described by @pbking seems to be caused by this commit dded23b The issue is related to the existence in the database of styles saved to "custom" key, example: Knowing this: should we add a few lines to handle this issue (move existing user custom styles from Personally, I think it would be simpler and make sense to continue using the I reverted the commit so you can test again @pbking. |
I think its fine to merge using the |
I concur with @scruffian. This fixes the issue at hand and we can address the "custom" bit in another PR. I removed the reference to this fixing #5448 in the description and I believe this is ready to come in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
Changes proposed in this Pull Request:
Related issue(s):
#5308