Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blockbase: Use the Global Styles rest API in the customizer #5308

Closed
scruffian opened this issue Jan 13, 2022 · 1 comment · Fixed by #5492
Closed

Blockbase: Use the Global Styles rest API in the customizer #5308

scruffian opened this issue Jan 13, 2022 · 1 comment · Fixed by #5492
Assignees
@matiasbenedetto
Labels
[Theme] Blockbase

Comments

@scruffian
Copy link
Member

scruffian commented Jan 13, 2022 •
edited
Loading

In WordPress/gutenberg#35801 a Global Styles API was introduced. We should reconsider the implementation of our Customizer/Global Styles bridge, to take advantage of this new API.

Alternatively we could just use the new style switcher in Gutenberg.

From #5307
@MaggieCabrera
Copy link
Contributor

I agree. Skatepark could have different variations with and without duotone and avoid the customizer route altogether

@MaggieCabrera MaggieCabrera added the [Theme] Skatepark Automatically generated label for Skatepark. label Jan 25, 2022
@matiasbenedetto matiasbenedetto self-assigned this Feb 1, 2022
@matiasbenedetto matiasbenedetto mentioned this issue Feb 9, 2022
Merged
@matiasbenedetto matiasbenedetto linked a pull request Feb 9, 2022 that will close this issue
Blockbase: Use the Global Styles rest API in the customizer #5492
Merged
@MaggieCabrera MaggieCabrera removed the [Theme] Skatepark Automatically generated label for Skatepark. label Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matiasbenedetto matiasbenedetto

Labels
[Theme] Blockbase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Blockbase: Use the Global Styles rest API in the customizer Automattic/themes
3 participants
@scruffian @matiasbenedetto @MaggieCabrera