Blank Canvas Blocks: Add table styles #3503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
reviewed
Mar 22, 2021
| }, | ||
| "table": { | ||
| "typography": { | ||
| "fontSize": "var(--wp--preset--font-size--tiny)" |
There was a problem hiding this comment.
Can this declaration live directly under "styles" -> "core/table" now that we've decoupled block supports and theme.json for supported style attributes?
There was a problem hiding this comment.
No I don't think so because in this case it is being mapped to the caption, not the table itself. Maybe the format of the theme.json should better represent that?
There was a problem hiding this comment.
Yea, images and such keep that in a sub-object. Makes sense to do that here as well I think.
There was a problem hiding this comment.
Good call. Done in 6b8b6dd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This adds CSS to match the frontend to the editor for tables
Related issue(s):
#3413
Editor:
Frontend:
