Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blank Canvas Blocks] Evaluate Blocks #3413

Closed
26 of 29 tasks
pbking opened this issue Mar 8, 2021 · 5 comments
Closed
26 of 29 tasks

[Blank Canvas Blocks] Evaluate Blocks #3413

pbking opened this issue Mar 8, 2021 · 5 comments
Milestone

Comments

@pbking
Copy link
Contributor

pbking commented Mar 8, 2021

Ready the following blocks for Blank Canvas Blocks (A Ponyfill theme)

For each of the following blocks:

Evaluate "Blank Canvas Blocks" against "Blank Canvas"

If something can be achieved with Gutenberg theme.json styling for that block then leverage that first.

If something is expected to be achievable in Gutenberg, adjust the theme.json's "custom" block to express that opinion and add custom SASS to /sass/blocks consume those variables expressing that opinion.

(bcb demo)

@MaggieCabrera MaggieCabrera added this to the Blank Canvas Blocks milestone Mar 8, 2021
@pbking pbking changed the title Blank Canvas Blocks Parent Issue [Blank Canvas Blocks] Evaluate Blocks Mar 8, 2021
@jffng
Copy link
Contributor

jffng commented Mar 8, 2021

Should we consider certain FSE blocks too e.g. site title & tagline, post meta, tag cloud.

@pbking
Copy link
Contributor Author

pbking commented Mar 8, 2021

I think we should.

Do we have representation of that in Theamdemo? That would be a healthy addition if not.

@MaggieCabrera
Copy link
Contributor

I think we should totally add them to Theamdemo. I did add the "Archives" block to it because I needed it for another issue, so having the rest will be very helpful. This is a list of all the blocks on Theamdemo that need updating: #3350

@pbking
Copy link
Contributor Author

pbking commented Mar 9, 2021

While evaluating the buttons block I discovered this error which will be a blocker: WordPress/gutenberg#29675

@pbking
Copy link
Contributor Author

pbking commented Mar 23, 2021

Core blocks evaluated, styled and ponyfilled where necessary.

Closing this up; additional singular changes can be opened as needed.

@pbking pbking closed this as completed Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants