Multiple Themes: Use of $(window).load() clashes with ads

[laurelfulford]

We've had a few reports of sites using Rowling and Rebalance not loading when ads were enabled, and Goran not loading completely (header isn't visible).

The issue looks to be related to these themes using $(window).load() to show the header, or full content, in these themes. It's not working well with something in the ads code.

Swapping to $(document).ready() seems to fix the above issue, but may have unintended consequences. So it will need to be tested with each theme carefully to make sure it's a good replacement, and if no, look for other alternatives.

More details and related tickets here: pNEWy-bRB-p2

(Edited to add) Affected themes (there may be more):

• Rowling ✅
• Rebalance ✅
• Goran ✅
• Baskerville 2 ✅
• Textbook ✅
• Illustratr ✅
• Altofocus ✅

[KokkieH]

I commented on the P2, but in case you missed it, I've also observed the issue with Baskerville-2, Pinboard, Textbook, Illustratr, and Altofocus thus far.

[laurelfulford]

Thanks @KokkieH! I was just coming here to add those after I realized I'd missed them from the thread 😅

I'm updating the issue description to include a list, so we don't lose track!

[akmyta]

Another reported issue: #1125244-zen
Theme: Rowling

[laurelfulford]

Patch for Rowling here: D12613-code. I've removed the part where the content is hidden in the first place, because it doesn't seem needed in this theme. I'd appreciate your thoughts on this one, @allancole, if you think this change is over-reaching!

[laurelfulford]

Patch for Baskerville 2 here: D12659-code.

[laurelfulford]

Patch for Goran here: D12660-code

[laurelfulford]

Edited the main post to remove Pinboard since it's a premium theme; moved here: 2358-wpcom-premium-themes

[laurelfulford]

For Illustratr's fix (#114), it addresses the missing content issue, but there is other JavaScript (like the bit to make images wider than the content) that doesn't seem to work the same with $(document).ready(). I've left them as is for now since the pressing problem was the projects not displaying; we can circle back as need be.

[laurelfulford]

I'm going to close this because all of the listed themes have been patched. Will follow up in the related P2 threads; I've also added a comment to #1125244-zen.

[gpmw]

Reporting another instance of this here with the Oxygen theme.
#1135929-zen

[laurelfulford]

Thanks for the report, @gpmw!

This sounds like it is related to the ads somehow, but doesn't seem to be theme-specific. I can recreate it using another theme (Independent Publisher 2), and the issue seems to be related to the Gallery slideshow carousel, not anything specific in the themes.

I think this should be reported in the Jetpack repo, with all the steps to recreate: https://github.com/automattic/jetpack

The endless page load that's mentioned in the ticket also can't be fixed on the theme-level -- that's something happening on the ads side, and can still happen with the themes I updated here.

I also should have noted when I closed out this ticket -- any new reports of issues with themes and ads should go in their own individual tickets. I'd grouped the original set into one, but new reports will be harder to spot if they're tacked on here :)

[laurelfulford]

There was already an existing issue -- moved here: Automattic/jetpack#6244

[gpmw]

Thanks!

[rclations]

Is it possible to patch Cubic as well?

User report: C03TY6J1A/p1539719524000100-slack-livechat

[kathleenjross]

The user followed up 7335989-hc.

[laurelfulford]

Thanks for the report @rclations and @kathleenjross!

I've moved this to #289 for visibility.

Just to reiterate, because these kinds of comments get lost very easily in longer tickets like this:

Any new reports of issues with themes and ads should go in their own individual tickets. I'd grouped the original set into one, but new reports will be harder to spot if they're tacked on here, and it's hard know who's following up with what! :)